Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor mobile view adjustments for portrait mode #35919

Merged
merged 1 commit into from Jul 30, 2019

Conversation

ChrisEdS
Copy link
Contributor

@ChrisEdS ChrisEdS commented Jul 24, 2019

Description

On mobile devices, it happened that filenames and folder names could not be read. With some small adjustment, I fixed this behavior for screens that are 768px or less. The landscape mode gives an overview of filesize and the modification date.

Motivation and Context

The UI of Phoenix will be much better here. Still, while we're perfecting Phoenix, this PR helps make our old frontend a little better to use.

How Has This Been Tested?

  • Manual tested

Screenshots:

Before After
iPhone8_before iPhone8_after
Pixel2_before Pixel2_after
SE_before SE_after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport

@micbar
Copy link
Contributor

micbar commented Jul 25, 2019

@ChrisEdS Random CI failure. Please force push

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #35919 into master will decrease coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35919      +/-   ##
============================================
- Coverage     67.18%    65.8%   -1.39%     
  Complexity    18760    18760              
============================================
  Files          1168     1229      +61     
  Lines         63575    70856    +7281     
  Branches          0     1289    +1289     
============================================
+ Hits          42716    46626    +3910     
- Misses        20859    23852    +2993     
- Partials          0      378     +378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (?) 0 <ø> (?)
#phpunit 67.18% <ø> (ø) 18760 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentcollection.js 72.72% <0%> (ø) 0% <0%> (?)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794f9b6...1dbe500. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #35919 into archive/master will decrease coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             archive/master   #35919      +/-   ##
====================================================
- Coverage             67.19%    65.8%   -1.39%     
+ Complexity            18762    18760       -2     
====================================================
  Files                  1168     1229      +61     
  Lines                 63580    70856    +7276     
  Branches                  0     1289    +1289     
====================================================
+ Hits                  42720    46626    +3906     
- Misses                20860    23852    +2992     
- Partials                  0      378     +378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (?) 0 <ø> (?)
#phpunit 67.18% <ø> (-0.01%) 18760 <ø> (-2)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/ConnectionFactory.php 89.85% <0%> (-0.56%) 20% <0%> (-2%)
core/Command/Maintenance/Install.php 0% <0%> (ø) 20% <0%> (-1%) ⬇️
lib/private/Setup/AbstractDatabase.php 0% <0%> (ø) 12% <0%> (ø) ⬇️
lib/private/Setup/OCI.php 0% <0%> (ø) 36% <0%> (+1%) ⬆️
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cdd07...2b2c1c9. Read the comment docs.

@patrickjahns
Copy link
Contributor

@ChrisEdS awesome 🚀 - does this also work with the enterprise theme?

@ChrisEdS
Copy link
Contributor Author

@ChrisEdS awesome 🚀 - does this also work with the enterprise theme?

Yes, the changes were made inside the Files App itself.

@DeepDiver1975 DeepDiver1975 changed the base branch from master to archive/master July 30, 2019 08:23
Adjust the padding of .filesize
@DeepDiver1975 DeepDiver1975 changed the base branch from archive/master to master July 30, 2019 08:25
@DeepDiver1975 DeepDiver1975 merged commit 3d5a259 into master Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the mobile-view-adjustments branch July 30, 2019 11:05
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants