Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE doesn't redirect to login page when user is not logged in #36079

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Aug 22, 2019

Description

send html response when the client says any content-type is acceptable

Motivation and Context

  1. IE 11 is set as a default browser
  2. ownCloud User on Windows clicks on ownCloud private permalink (included in e.g. email)

Expected behavior

IE opens and login page is presented

Actual behavior

IE opens and user receives download dialog to download a file of 43 bytes (which is the uid of the user)
User needs to change URL to point to ../login.php and authenticate there

How Has This Been Tested?

Not tested yet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #36079 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36079   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0856f5c...4f77216. Read the comment docs.

@VicDeo VicDeo added this to the development milestone Aug 28, 2019
@VicDeo VicDeo added blue-ticket p2-high Escalation, on top of current planning, release blocker labels Aug 28, 2019
@VicDeo VicDeo force-pushed the fix-e3474 branch 2 times, most recently from 6fcca2f to 73439a1 Compare August 28, 2019 11:23
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 2bf651f into master Aug 29, 2019
@PVince81 PVince81 deleted the fix-e3474 branch August 29, 2019 11:34
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - To Review blue-ticket p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants