New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check Etag in header of file-operation responses #36116
Conversation
impl issue or test issue ? |
https://drone.owncloud.com/owncloud/core/20444/55/12 Both "old" and "new" fail the same:
The failure message is not helpful - need to see what the Actually it seems that an Etag is not returned in the header. For copy with or without overwrite, what is the expected Etag response? |
cb09f71
to
459d3e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #36116 +/- ##
=======================================
Coverage 54% 54%
=======================================
Files 63 63
Lines 7403 7403
Branches 1308 1308
=======================================
Hits 3998 3998
Misses 3019 3019
Partials 386 386
Continue to review full report at Codecov.
|
@phil-davis @PVince81 I think its a test issue, there is no Etag header after a COPY operation and actually that is correct I think |
459d3e2
to
53c45a9
Compare
random CI failures in the clone step, restarted |
Description
Check the Etags in the headers of file-operations
I've only added the checks where I thought it makes sense other requests that are not soo much different don't get checked
Related Issue
Types of changes
Checklist:
Open tasks: