Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check Etag in header of file-operation responses #36116

Merged
merged 1 commit into from Aug 30, 2019
Merged

Conversation

individual-it
Copy link
Member

Description

Check the Etags in the headers of file-operations
I've only added the checks where I thought it makes sense other requests that are not soo much different don't get checked

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@PVince81
Copy link
Contributor

impl issue or test issue ?

@phil-davis
Copy link
Contributor

phil-davis commented Aug 29, 2019

--- Failed scenarios:
/drone/src/tests/acceptance/features/apiWebdavProperties/copyFile.feature:21
/drone/src/tests/acceptance/features/apiWebdavProperties/copyFile.feature:22
/drone/src/tests/acceptance/features/apiWebdavProperties/copyFile.feature:34
/drone/src/tests/acceptance/features/apiWebdavProperties/copyFile.feature:35
92 scenarios (88 passed, 4 failed)
637 steps (629 passed, 4 failed, 4 skipped) 

https://drone.owncloud.com/owncloud/core/20444/55/12

Both "old" and "new" fail the same:

Examples:
| dav_version |
| old |
'/^"[a-f0-9]{1,32}"$/' does not match ''
Failed asserting that false is not false.
| new |
'/^"[a-f0-9]{1,32}"$/' does not match ''
Failed asserting that false is not false.

The failure message is not helpful - need to see what the Etag value actually is.
My guess will be that it is missing the double-quotes.
@individual-it ?

Actually it seems that an Etag is not returned in the header. For copy with or without overwrite, what is the expected Etag response?

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #36116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36116   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa17f5...53c45a9. Read the comment docs.

@individual-it
Copy link
Member Author

@phil-davis @PVince81 I think its a test issue, there is no Etag header after a COPY operation and actually that is correct I think

@individual-it
Copy link
Member Author

random CI failures in the clone step, restarted

@individual-it individual-it merged commit c9f1d87 into master Aug 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the checkHeaderEtag branch August 30, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants