Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sabre/vobject (4.2.1 => 4.2.2) #36757

Closed
wants to merge 2 commits into from
Closed

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 14, 2020

Description

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating sabre/vobject (4.2.1 => 4.2.2): Downloading (100%)   

https://github.com/sabre-io/vobject/releases/tag/4.2.2

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis added 2 - Developing dependencies php Pull requests that update Php code labels Jan 14, 2020
@phil-davis phil-davis self-assigned this Jan 14, 2020
@phil-davis phil-davis marked this pull request as ready for review January 14, 2020 10:44
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #36757 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36757   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19118    19118           
=========================================
  Files          1269     1269           
  Lines         74775    74775           
  Branches       1320     1320           
=========================================
  Hits          48369    48369           
  Misses        26018    26018           
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19118 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d197d60...f9e4e5d. Read the comment docs.

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 @micbar this has already been applied to release-10.4.0
can we also merge this PR to master?
because dependabot is looking for changes in master, all other dependency PRs are already merged in master, so it would be nice that we don't have this dependency missing from master.

@phil-davis
Copy link
Contributor Author

This is already in release-10.4.0 branch that was just merged to master. So no need for this PR.

@phil-davis phil-davis closed this Jan 15, 2020
@phil-davis phil-davis deleted the sabre-vobject-4.2.2 branch January 15, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - To Review dependencies php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant