Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/dropzone in drop folder #37116

Merged
merged 3 commits into from Mar 12, 2020
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Mar 12, 2020

Description

  • fix some translations
  • add message for the user that uploading files is not possible in a readonly folder

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot from 2020-03-12 13-33-37
Screenshot from 2020-03-12 12-27-23

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #37116 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37116   +/-   ##
=========================================
  Coverage     64.78%   64.78%           
  Complexity    19133    19133           
=========================================
  Files          1270     1270           
  Lines         74914    74914           
  Branches       1328     1328           
=========================================
  Hits          48531    48531           
  Misses        25993    25993           
  Partials        390      390           
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.96% <ø> (ø) 19133.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files/templates/list.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
core/js/js.js 55.05% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f348e...bfb2c82. Read the comment docs.

Copy link
Contributor

@ChrisEdS ChrisEdS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRGTM

@DeepDiver1975 DeepDiver1975 merged commit 2e35f35 into master Mar 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/dropzone-in-drop-folder branch March 12, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants