Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sharing with uids in numerical format #37336

Merged
merged 3 commits into from May 6, 2020
Merged

Fix sharing with uids in numerical format #37336

merged 3 commits into from May 6, 2020

Commits on May 6, 2020

  1. array key can be numeric, use uid string in response

    @karakayasemi @phil-davis
    karakayasemi authored and phil-davis committed May 6, 2020
    Configuration menu
    Copy the full SHA
    ff15d96 View commit details
    Browse the repository at this point in the history

  2. validate shareWith parameter is string in createShare api

    @karakayasemi @phil-davis
    karakayasemi authored and phil-davis committed May 6, 2020
    Configuration menu
    Copy the full SHA
    cc56244 View commit details
    Browse the repository at this point in the history

  3. Add acceptance tests for sharing with unusual usernames

    @phil-davis
    phil-davis committed May 6, 2020
    Configuration menu
    Copy the full SHA
    2effe65 View commit details
    Browse the repository at this point in the history