Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] skipOnOcV10.5.0 cliMain securityCertificates features #37802

Merged
merged 1 commit into from Aug 11, 2020

Conversation

phil-davis
Copy link
Contributor

Description

https://drone.owncloud.com/owncloud/user_ldap/2703/142/12 fails:

--- Failed scenarios:

    /var/www/owncloud/testrunner/tests/acceptance/features/cliMain/securityCertificates.feature:17
    /var/www/owncloud/testrunner/tests/acceptance/features/cliMain/securityCertificates.feature:45

53 scenarios (51 passed, 2 failed)
311 steps (307 passed, 2 failed, 2 skipped)

Those tests were created/adjusted in PR #37783 which fixed the expected exit status of security:certificates commands.

The test scenarios will not pass on ownCloud 10.5.0, so skip them in that case. (note the whole of securityCertificates.feature is already skipped on 10.3 and 10.4)

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis merged commit c3141ae into master Aug 11, 2020
@phil-davis phil-davis deleted the cli-securityCertificates-skipOnOc10.5.0 branch August 11, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants