Better messages #3827
Better messages #3827
Conversation
|
Up to now we did not translate these setup messages. |
|
Don't like the specification of target for links. Users should be able to decide on their own where links open. |
|
@bantu it’s a web app, links should not load in the same window. |
|
@DeepDiver1975 probably yes? What do you think? |
|
added OC_Defaults call for the base url, otherwise it looks good to me 👍 |
| @@ -104,7 +104,7 @@ | |||
| <fieldset class="personalblock"> | |||
| <legend><strong><?php p($l->t('WebDAV'));?></strong></legend> | |||
| <code><?php print_unescaped(OC_Helper::linkToRemote('webdav')); ?></code><br /> | |||
| <em><?php p($l->t('Use this address to connect to your ownCloud in your file manager'));?></em> | |||
| <em><?php print_unescaped($l->t(sprintf('Use this address to <a href="%s/server/5.0/user_manual/files/files.html" target="_blank">access your Files via WebDAV</a>', OC_Defaults::getDocBaseUrl()) ));?></em> | |||
There was a problem hiding this comment.
this sprintf inside t() will not work.
t() can take arguments an interpolate the translated string
let's leave it as it is - the admin will see this once/never. |
|
Can we get another tester here? |
|
(cc @bantu @DeepDiver1975 ;) |
|
This should go in for 5.0.8 and the EE release, right @jancborchardt . |
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| <?php $defaults = new OC_Defaults(); // initialize themable default strings and urls ?> | |||
|
|
|||
| <?php $defaults = new OC_Defaults(); // initialize themable default strings and urls ?> | |||
|
@schiesbn I'm fine with that 👍 |
|
Merged: 9b9ea7c |
|
backported to stable5: 54a1239 |
Improving the error messages on installation by linking to the documentation. The documentation links should ideally be moved to the defaults.php, can you help with that @schiesbn? Is the only thing needing change in the doc url .org to .com?
Also changed the WebDAV sentence to link to the docs, same here.
cc @DeepDiver1975 regarding #3819