Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add API test for deleting a share with wrong authentication #38336

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 25, 2021

Description

adds API test for trying to delete a share with wrong auhentication

Note: needs to be added in expected_to_fail file in ocis

Related Issue

How Has This Been Tested?

  • test environment: local

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@saw-jan saw-jan self-assigned this Jan 25, 2021
@saw-jan saw-jan changed the title [Tests-Only] Add API tests for deleting a share with wrong authentication [Tests-Only] Add API test for deleting a share with wrong authentication Jan 25, 2021
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/28363/68/13

Running apiShareManagementBasicToRoot tests tagged ~@skipWhenTestingRemoteSystems&&~@skipOnOcV10&&~@skipOnOcV10.6&&~@skipOnOcV10.6.1&&@api&&~@skip 

In Parser.php line 478:
                                                                                                                                                                             
  [Behat\Gherkin\Exception\ParserException]                                                                                                                                  
  Expected Step or Examples table, but got Outline on line: 408 in file: /drone/src/tests/acceptance/features/apiShareManagementBasicToRoot/createShareToRootFolder.feature  
                                                                                                                                                                             

Exception trace:

There is a problem with the new Behat/Gherkin v4.7.0 - issue Behat/Gherkin#187

I have a fix ready: Behat/Gherkin#189

If that is merged and released soon, then CI will be great again.

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 22de67c into master Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the expand-deleteshare-test branch January 26, 2021 12:28
saw-jan added a commit that referenced this pull request Jan 27, 2021
saw-jan added a commit that referenced this pull request Jan 27, 2021
phil-davis added a commit that referenced this pull request Jan 27, 2021
[Tests-Only] Refactor API tests added in PRs #38336 and #38326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants