add http client request_fulluri option only if a proxy configured #38738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have added the HTTP client
request_fulluri
option to all DAV requests with #34101 when fixing federated shares behind proxy servers.According to https://www.php.net/manual/en/context.http.php, http
request_fulluri
option only needed when a proxy configured and some webdav service providers are not able to respond properly when this option set without proxy. This pr adds HTTP clientrequest_fulluri
option only if a proxy configured.Related Issue
Motivation and Context
Solving bugs.
How Has This Been Tested?
Manually tested by sharing a federated share from nextcloud to owncloud. ownCloud user is able to download the share after this change.
Types of changes
Checklist: