Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http client request_fulluri option only if a proxy configured #38738

merged 1 commit into from
May 17, 2021


Copy link

@karakayasemi karakayasemi commented May 16, 2021


We have added the HTTP client request_fulluri option to all DAV requests with #34101 when fixing federated shares behind proxy servers.

According to, http request_fulluri option only needed when a proxy configured and some webdav service providers are not able to respond properly when this option set without proxy. This pr adds HTTP client request_fulluri option only if a proxy configured.

Related Issue

Motivation and Context

Solving bugs.

How Has This Been Tested?

Manually tested by sharing a federated share from nextcloud to owncloud. ownCloud user is able to download the share after this change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)


  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@karakayasemi karakayasemi self-assigned this May 16, 2021
@karakayasemi karakayasemi requested a review from micbar May 16, 2021 21:10
Copy link

sonarcloud bot commented May 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@owncloud owncloud deleted a comment from update-docs bot May 17, 2021
@AlexAndBear AlexAndBear merged commit 72d2d5c into master May 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-nextcloud-federation branch May 17, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants