Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration by loading the app without checking, after correct update #38773

Merged
merged 2 commits into from May 27, 2021

Conversation

jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented May 25, 2021

Description

Some problems were detected with the upgrade from 10.5 to 10.8 (still in alpha state) related to the PR #38728 .
This new PR aims to fix the problems detected so far with the migration

Related Issue

Related to #38770
Linked with #38728

Motivation and Context

How Has This Been Tested?

  1. Install OC 10.5 and WND app 1.1.0
  2. Mount a GDrive and WND mount points (WND with username+password)
  3. Ensure you can access to the files inside the GDrive and WND
  4. Update OC to this branch (future 10.8) and update WND to 2.0.0
  5. Run the upgrade

Passwords have been migrated correctly and the user can access to the files inside both storages without problems

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor

This is an adjustment to a previous PR, so IMO changelog is not needed (or add this PR to the previous changelog)

@jvillafanez if this is ready, it could be reviewed and merged today. So we will get a CI run overnight of update-testing.

@jvillafanez
Copy link
Member Author

jvillafanez commented May 25, 2021

Migration doesn't run properly... OC 10.5.0 -> 10.8.0 with WND username + password: the password is reset.
It would be interesting to know if this is the only case.

There is no crash so the upgrade goes through, but the fact that the password is reset will be annoying

@jvillafanez
Copy link
Member Author

Migration doesn't run properly...

Fixed with the last commit

@IljaN quick second check for the last commit? Otherwise this should be good to merge.

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jvillafanez jvillafanez mentioned this pull request May 26, 2021
11 tasks
@IljaN
Copy link
Member

IljaN commented May 27, 2021

LGTM!

@phil-davis phil-davis merged commit 4e285cf into master May 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_files_external_migration branch May 27, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants