Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission check when restoring from trashbin #39210

Merged
merged 1 commit into from Sep 10, 2021
Merged

Add permission check when restoring from trashbin #39210

merged 1 commit into from Sep 10, 2021

Conversation

JammingBen
Copy link
Contributor

Description

This fixes an issue where a user was able to restore a file or folder into a read-only shared folder.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

phil-davis
phil-davis approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if CI passes.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit b105952 into master Sep 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/35900 branch September 10, 2021 12:33
@phil-davis phil-davis mentioned this pull request Sep 11, 2021
Closed
@JammingBen JammingBen mentioned this pull request Sep 29, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@IljaN IljaN Awaiting requested review from IljaN

@mrow4a mrow4a Awaiting requested review from mrow4a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user can restore to read-only share
3 participants
@JammingBen @phil-davis @AlexAndBear