-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] add percent to usernames #39242
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be matching scenarios in of the apiProvisioning-v1/v2 suites.
One change has been made in apiProvisioning-v1 and 3 in apiProvisioning-v2.
Maybe there could/should be 4 changes in each?
Kudos, SonarCloud Quality Gate passed! |
💥 Acceptance tests pipeline apiProvisioning-v1-mariadb10.2-php7.4 failed. The build has been cancelled. |
The
So we know that the test cases in the first commit will not pass. I put the test cases for |
There was an unrelated fail - see issue #39244 |
we ran into this when trying a user that had an email as the username. ocis-web would encode the
@
as%40
and the chi router would not match the route. See go-chi/chi#659