[full-ci] Expiration date limits for reshare of a received share #39452
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
💥 Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled. |
|
💥 Acceptance tests pipeline apiShareUpdateToShares-mariadb10.2-php7.4 failed. The build has been cancelled. |
AlexAndBear
force-pushed
the
issues/37013
branch
from
c721b25
to
2fd804a
Compare
|
💥 Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled. |
tests/acceptance/features/apiShareReshareToShares3/reShareWithExpiryDate.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareReshareToShares3/reShareWithExpiryDate.feature
Outdated
Show resolved
Hide resolved
|
@janackermann any progress on that? Seems a reasonable change that could go into 10.11 |
…-share and has exp date set
| | 2 | no | | ||
| | ocs_api_version | default-expire-date | ocs_status_code | http_status_code | | ||
| | 1 | yes | 996 | 200 | | ||
| | 2 | yes | 500 | 500 | |
There was a problem hiding this comment.
ToDo: we should not expect a 500 HTTP or OCS status code. Needs to be sorted out.
| | 1 | yes | 996 | 200 | | ||
| | 2 | yes | 500 | 500 | | ||
| | 1 | no | 996 | 200 | | ||
| | 2 | no | 500 | 500 | |
There was a problem hiding this comment.
ToDo: we should not expect a 500 HTTP or OCS status code. Needs to be sorted out.
| | 2 | | ||
| | ocs_api_version | default-expire-date | ocs_status_code | http_status_code | | ||
| | 1 | yes | 996 | 200 | | ||
| | 2 | yes | 500 | 500 | |
There was a problem hiding this comment.
ToDo: we should not expect a 500 HTTP or OCS status code. Needs to be sorted out.
|
💥 Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled. |
phil-davis
changed the title
|
I rebased this in #40263 - if that works nicely, we can probably close this old PR. |
Description
With this change, if a user re-shares an existent share with an expiration date,
the expiration date of the target share will be taken for the new share,
if the user doesn't provide an expiration date.
If the expiration date is provided and exceeds the date of the target share,
an error will be thrown.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: