Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting the file owner for share recipients #39670

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 10, 2022

Description

Fixed a bug where a wrong file owner was retrieved when saving version authors. This scenario happened for share recipients if they had a file with the same name as the shared one.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

JammingBen added a commit that referenced this pull request Jan 10, 2022
@owncloud owncloud deleted a comment from update-docs bot Jan 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@IljaN IljaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR #39675 - that has 2 new scenarios that demonstrate this issue, and they pass with this code.

I can't just cherry-pick those in here, because they need various test code from master that is not in the release-10.9.1 branch. If we want, we could merge #39639 to release-10.9.1 to get all that test code into the release branch. But it might be best not to do that - we might accidentally cause some merge problem back to master...

When we merge back things from release-10.9.1 to master (however we do that in a controlled way), we can also apply the test scenarios to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants