\OC\Preview

[georgehrke]

OC\Preview

This pull requests contains the implementation of the class \OC\Preview.
It also contains updated versions of the files, files_sharing and the files_trashbin app. Those apps make now use of the new preview lib.
To test this pull request, you might need to checkout https://github.com/owncloud/3rdparty/tree/oc_preview

please review
@karlitschek
@jancborchardt
@DeepDiver1975
@LukasReschke

[DeepDiver1975]

@georgehrke disabled preview fixed? THX

[georgehrke]

What do you mean by disabled previews?
invert disable_previews to enable_previews -> done
show mimetype icon after upload if previews are disabled -> done

[DeepDiver1975]

show mimetype icon after upload if previews are disabled -> done

this is what I was talking about - thx

[DeepDiver1975]

I'll review this tonight and let's merge then

[georgehrke]

Thx

Please excuse my brevity and typos.
Sent from my iPhone

On Aug 30, 2013, at 7:54 PM, Thomas Müller notifications@github.com wrote:

I'll review this tonight and let's merge then

—
Reply to this email directly or view it on GitHub.

[DeepDiver1975]

@jancborchardt @georgehrke there is something wrong with the color on the file actions - THX

[DeepDiver1975]

That's the reason why I get no previews on my vids:
Buffering several frames is not supported. Please consume all available frames before adding a new one.

Input #0, avi, from 'PICT0075.AVI':
  Metadata:
    encoder         : 
  Duration: 00:00:02.99, start: 0.000000, bitrate: 17399 kb/s
    Stream #0.0: Video: mjpeg, yuvj422p, 640x480, 30 tbr, 30 tbn, 30 tbc
    Stream #0.1: Audio: pcm_u8, 8000 Hz, 1 channels, u8, 64 kb/s
[buffer @ 0x23ad1a0] w:640 h:480 pixfmt:yuvj422p
Output #0, mjpeg, to '/tmp/test.jpeg':
  Metadata:
    encoder         : Lavf53.21.1
    Stream #0.0: Video: mjpeg, yuvj422p, 640x480, q=2-31, 200 kb/s, 90k tbn, 30 tbc
Stream mapping:
  Stream #0.0 -> #0.0
Press ctrl-c to stop encoding
[buffer @ 0x23ad1a0] Buffering several frames is not supported. Please consume all available frames before adding a new one.
    Last message repeated 30 times
frame=    1 fps=  0 q=3.6 Lsize=      22kB time=0.03 bitrate=5331.1kbits/s    
video:22kB audio:0kB global headers:0kB muxing overhead 0.000000%

[DeepDiver1975]

@georgehrke we need a proper documentation on which tools are required to enable previews of which type

@ringmaster windows server testing on this is highly necessary - at the moment this is pure linux based implementation - THX

[georgehrke]

@georgehrke we need a proper documentation on which tools are required to enable previews of which type

I'll write some doc when this was merged

[jancborchardt]

@DeepDiver1975 the fileactions color is an issue from master, will be fixed by @petemcfarlane in #4665

[georgehrke]

@DeepDiver1975 the fileactions color is an issue from master, will be fixed by @petemcfarlane in #4665

Already fixed it with previous commit

[georgehrke]

That's the reason why I get no previews on my vids:
Buffering several frames is not supported. Please consume all available frames before adding a new one.

I'm no ffmpeg cl expert. Does anyone know how to do this with ffmpeg?

[DeepDiver1975]

I'll write some doc when this was merged

hehe - would have been great to have this information while testing

libreoffice docs are working now as well

[DeepDiver1975]

I'm no ffmpeg cl expert. Does anyone know how to do this with ffmpeg?

we should anyhow more to avconv as the depreciation warning suggests

And well - as usual - Google is your friend:
https://lists.ffmpeg.org/pipermail/ffmpeg-user/2011-April/000231.html

😉

[Niduroki]

Gave this a quick test.

While uploading loads of stuff my log gets slowly spammed with this:

{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OC\\Preview' does not have a method 'post_write' at \/home\/http\/testcloud\/lib\/hook.php#72","level":2,"time":"August 30, 2013 20:44:37"}
{"app":"core","message":"Path not in cache: files\/","level":3,"time":"August 30, 2013 20:44:38"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OC\\Preview' does not have a method 'post_write' at \/home\/http\/testcloud\/lib\/hook.php#72","level":2,"time":"August 30, 2013 20:45:01"}
{"app":"core","message":"Path not in cache: files\/","level":3,"time":"August 30, 2013 20:45:02"}

When navigating into a path with many files the log quickly fills with:

{"app":"PHP","message":"is_file() expects parameter 1 to be a valid path, string given at \/home\/http\/testcloud\/lib\/image.php#395","level":2,"time":"August 30, 2013 20:45:11"}
{"app":"PHP","message":"is_file() expects parameter 1 to be a valid path, string given at \/home\/http\/testcloud\/lib\/image.php#395","level":2,"time":"August 30, 2013 20:45:11"}
{"app":"PHP","message":"is_file() expects parameter 1 to be a valid path, string given at \/home\/http\/testcloud\/lib\/image.php#395","level":2,"time":"August 30, 2013 20:45:11"}

PHP 5.5.2, opensuse 12.3, nginx 1.5.3

[DeepDiver1975]

on the public share by link page there is a javascript error - no idea if that is related:

Uncaught ReferenceError: file_upload_param is not defined public.js?v=681a23b0649e61ca572cb5bb8db206ec:54
(anonymous function) public.js?v=681a23b0649e61ca572cb5bb8db206ec:54
c jquery-1.10.0.min.js?v=681a23b0649e61ca572cb5bb8db206ec:4
p.fireWith jquery-1.10.0.min.js?v=681a23b0649e61ca572cb5bb8db206ec:4
x.extend.ready jquery-1.10.0.min.js?v=681a23b0649e61ca572cb5bb8db206ec:4
q jquery-1.10.0.min.js?v=681a23b0649e61ca572cb5bb8db206ec:4

[georgehrke]

on the public share by link page there is a javascript error - no idea if that is related:

I don't think so

[georgehrke]

While uploading loads of stuff my log gets slowly spammed with this:

There definitely is a method post_write
see https://github.com/owncloud/core/blob/oc_preview/lib/preview.php#L595

@icewind1991 Any idea?

[ghost]

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/791/

[DeepDiver1975]

@georgehrke will be off for vacation now

@karlitschek @jancborchardt I'd vote for merge now - remaining cleanup can be done afterwards - we need to get this going - any objections?

👍

[karlitschek]

No. Please merge 👍

[karlitschek]

Yay. Thanks a lot Georg

[MorrisJobke]

Awesome!