Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Show Username on personal profile settings page #40510

Merged
merged 4 commits into from Jan 31, 2023
Merged

[full-ci] Show Username on personal profile settings page #40510

merged 4 commits into from Jan 31, 2023

Conversation

T0mWz
Copy link
Contributor

@T0mWz T0mWz commented Nov 23, 2022

Description

When you make use of an external identity provider, for example Shibboleth or OIDC.
Your username within the environment may be different from the one you use to log in to the IdP.
When autocomplete is disabled for sharing and your full username have to be entered, then it's handy to know what's your username

How Has This Been Tested?

  • Applied within own environment

Screenshots (if appropriate):

Screenshot 2022-11-23 at 10 36 27

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Todo:

  • Translation option should be added.

@T0mWz T0mWz changed the title Username profile Show Username on personal profile settings page Nov 23, 2022
@CLAassistant
Copy link

CLAassistant commented Nov 23, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@mmattel
Copy link
Contributor

mmattel commented Jan 30, 2023

@phil-davis can you kick CI ?

@phil-davis phil-davis changed the title Show Username on personal profile settings page [full-ci] Show Username on personal profile settings page Jan 31, 2023
@owncloud owncloud deleted a comment from update-docs bot Jan 31, 2023
@phil-davis
Copy link
Contributor

@tomwezepoel @T0mWz please click the buttons to "sign" the CLA.

@phil-davis
Copy link
Contributor

@DeepDiver1975 @jvillafanez or anyone, please review.

This seems to be a sensible thing to show on the Personal General Settings page. In the past, after changing my full name (display name) I have wondered what my actual username is, and couldn't see it displayed anywhere.

@phil-davis phil-davis self-assigned this Jan 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.6% 72.6% Coverage
1.7% 1.7% Duplication

DeepDiver1975
DeepDiver1975 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue in showing the username

@mmattel mmattel merged commit 8432109 into owncloud:master Jan 31, 2023
@jnweiger
Copy link
Contributor

Included in 10.12.0-rc.1, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@jvillafanez jvillafanez jvillafanez approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees

@phil-davis phil-davis

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@T0mWz @CLAassistant @mmattel @phil-davis @jnweiger @DeepDiver1975 @jvillafanez @tomwezepoel