Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Remove loader in ChunkLocationProvider.php #40719

Merged
merged 1 commit into from Apr 3, 2023

Conversation

pako81
Copy link
Contributor

@pako81 pako81 commented Apr 3, 2023

Description

Remove loader in ChunkLocationProvider.php. Follow-up of #40700.

Related Issue

Motivation and Context

File Firewall acceptance tests were failing after merging #40693 as we changed the position of the loader in the constructor. We now remove the loader and use the empty storage factory.

How Has This Been Tested?

Ran File Firewall acceptance tests locally and make sure that following scenarios pass (they were previously failing):

webUILimitUpload/limituploadbasedonsize.feature:29
webUILimitUpload/limituploadbasedonsize.feature:37
webUILimitFileAccess/limitfileaccessbasedonrequesttype.feature:13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@pako81 pako81 added this to the development milestone Apr 3, 2023
@pako81 pako81 requested a review from jnweiger April 3, 2023 12:10
@pako81 pako81 self-assigned this Apr 3, 2023
@update-docs
Copy link

update-docs bot commented Apr 3, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the clean restart.
My history in 40700 was all over the place. Sorry for the mess.
This superceeds #40700

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jnweiger jnweiger merged commit a739b40 into master Apr 3, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the revert_chunklocationprovider_loader branch April 3, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants