Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the requested open mode is set in the checksum wrapper #40832

Merged
merged 3 commits into from Jun 14, 2023
Merged

Ensure the requested open mode is set in the checksum wrapper #40832

merged 3 commits into from Jun 14, 2023

Conversation

jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented Jun 8, 2023 •
edited

Description

Checksum was being discarded because the detected mode was wrong and we couldn't ensure the checksum was correctly calculated.

Related Issue

#40831

Motivation and Context

The issue was preventing uploads to external storages

How Has This Been Tested?

Manually tested with a SFTP storage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Jun 8, 2023
@jvillafanez jvillafanez mentioned this pull request Jun 8, 2023
Closed
@jvillafanez jvillafanez marked this pull request as ready for review June 8, 2023 11:36
@owncloud owncloud deleted a comment from update-docs bot Jun 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jnweiger
Copy link
Contributor

jnweiger commented Jun 9, 2023

Probably also helpful for #40809 ?

@jnweiger jnweiger mentioned this pull request Jun 9, 2023
Closed
2 tasks
@IljaN IljaN self-requested a review June 12, 2023 07:54
@pako81
Copy link
Contributor

pako81 commented Jun 14, 2023

merge it?

@jvillafanez jvillafanez merged commit 8784bc7 into master Jun 14, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix_checksum_mode branch June 14, 2023 13:08
@Salipa-Gurung
Copy link

Salipa-Gurung commented Aug 16, 2023 •
edited

Tested with:
Client: ownCloud 4.2.0.11670 f5a29b
Server version : ownCloud 10.13.0 beta 1 (stable)

Screenshot from 2023-08-16 15-06-14 Screenshot from 2023-08-16 15-06-48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees

@jvillafanez jvillafanez

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jvillafanez @jnweiger @pako81 @Salipa-Gurung @IljaN @DeepDiver1975 @phil-davis