fix: DAV storage should return false on stat() if connection fails

[DeepDiver1975]

Description

DAV::stat() is returning an empty array when the propfind fails. As a result when a non-WebDAV servers can be mounted and cause followup issues for the end user.

How Has This Been Tested?

• Hook up any other WebDAV server in external storage settings -> green
• Hook up any http server -> red
• (proving the wrong behavior before the patch is only of theoretical nature)

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

60.0% Coverage
0.0% Duplication

[phil-davis]

@DeepDiver1975 needs a changelog entry

[pako81]

@DeepDiver1975 maybe you want to try to add changelog and resolve the observations above (and add tests if needed?). So we can try to merge this till end of the week (10.13 code freeze). Thx

[phil-davis]

IMO @DeepDiver1975 is OOTO (on leave) for some time. He asked me to take over another PR, so I will adjust this one also...

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

80.0% Coverage
0.0% Duplication

[jnweiger]

Confirmed fixed in 10.13.0-rc.1