fix: DAV storage should return false on stat() if connection fails - #40861
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
Jul 31, 2023
Contributor
|
@DeepDiver1975 needs a changelog entry |
|
@DeepDiver1975 maybe you want to try to add changelog and resolve the observations above (and add tests if needed?). So we can try to merge this till end of the week (10.13 code freeze). Thx |
Contributor
|
IMO @DeepDiver1975 is OOTO (on leave) for some time. He asked me to take over another PR, so I will adjust this one also... |
phil-davis
self-requested a review
August 8, 2023 09:58
phil-davis
force-pushed
the
fix/webdav-stat
branch
from
August 8, 2023 10:01
d13f2c4 to
6aec2dd
Compare
phil-davis
force-pushed
the
fix/webdav-stat
branch
from
August 8, 2023 10:09
6aec2dd to
d9680c2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
Confirmed fixed in 10.13.0-rc.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DAV::stat() is returning an empty array when the propfind fails. As a result when a non-WebDAV servers can be mounted and cause followup issues for the end user.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: