Fix for 40872

[steelcuts]

Changed the share dropdown. It will expand to the page bottom now if there are more entries.

Description

Related Issue

• Fixes Add max-height to sharing dialog #40872

Motivation and Context

How Has This Been Tested?

• Local instance
• presales.owncloud.com

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[CLAassistant]

All committers have signed the CLA.

[hurradieweltgehtunter]

Thank you for your work and the PR! One question, though: what happens if the dropdowns' height exceeds the screen height to the bottom?
I haven't tested it, but it looks like, that the list will exceed the screen height if it's long enough and some elements will be hidden. Have you tested that?

[phil-davis]

@steelcuts please click the button to "sign" the CLA

[steelcuts]

What happens if the dropdowns' height exceeds the screen height to the bottom?

Thanks and good question:
You can see in the second screenshot that it already has reached its maximum height, there is a scrollbar to the right of it.
The combination of y-overflow (scroll if it can't expand further) and bottom margin ( always leave 15px space to the bottom ) let the dropdown behave this way.

please click the button to "sign" the CLA

Thanks for letting me know

[hurradieweltgehtunter]

Please test the following:

• Have the list as long as in your second screenshot
• Reduce your browsers window height so the lists bottom is lower than the window bottom, for example move the window bottom up until the bottom is at "admin-matthias"

I'm pretty sure that the user list will be cut off.
I hope the explanation is understandable. it's bit tricky since I cannot test it locally rn :)

[steelcuts]

I just retested and it didn't work at all. I didn't clear my cache and still had following css loaded:

max-height: -moz-available; 
max-height: -webkit-fill-available; 
max-height: fill-available;

I think that's what you where trying to say? :D

Now it behaves like i had intended:

[ChrisEdS]

Please only use common resolutions. Seems like this resolution is way to small - I see other misbehaviour here like

and

actually I think this is another bug! Should the Archivierte Dateien part be in the section of Gelöschte Dateien and Papierkorb?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[steelcuts]

You can test it here:
https://branding-aalvarez.owncloud.works/
user: demo_user
password: demo_password

Just search for the username "test"

[pako81]

What is the status here? @ChrisEdS is this needed for the 10.13 release?

[ChrisEdS]

I would love to have it in the release. @tbsbdr can you have a look?
#40873 (comment)