Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve images #40963

Merged
merged 2 commits into from Sep 1, 2023
Merged

Improve images #40963

merged 2 commits into from Sep 1, 2023

Conversation

jnweiger
Copy link
Contributor

  • Revamped the onlyoffice.png in gimp: cleaner and smaller PNG, ugly checkerboard background removed. (It was actually a 200k jpeg)
  • Replaced wopi.png with the logo found at github.com/OfficeDev/PnP-WOPI (it was a copy of the onlyoffic jpeg)

@jnweiger
Revamped the onlyoffice.png in gimp: cleaner and smaller PNG, ugly ch…
30009d1 
…eckerboard background removed. (It was actually a 200k jpeg)

Replaced wopi.png with the logo found at github.com/OfficeDev/PnP-WOPI (it was a copy of the onlyoffic jpeg)
@update-docs
Copy link

update-docs bot commented Aug 31, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jnweiger jnweiger changed the base branch from master to release-10.13.1 August 31, 2023 10:54
@DeepDiver1975
Copy link
Member

  • ugly checkerboard background removed

you killed the transparancy with that .....

phil-davis
phil-davis approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.
The other existing images are
drawio.png 5.11 KB
richdocuments.png 12.2 KB

So this makes onlyoffice.png and wopi.png have similar format and sizes.

DeepDiver1975
DeepDiver1975 requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped/missing transparancy needs to be coordinated with clients .....

@DeepDiver1975
Copy link
Member

@jnweiger you might want to apply https://www.conventionalcommits.org/en/v1.0.0/ to your commits ......

@phil-davis
Copy link
Contributor

Note: the existing drawio.png and richdocuments.png don't seem to have transparency - is that intended?

@jnweiger
Copy link
Contributor Author

None of them ever had transparency. The checkerboard background in that (jpeg!) icon was really a checkerboard background.

To make it look nice on non-white-background, i'd suggest to

  • keep a white margin, otherwise red green blue of e.g. the onlyoffice icon could blend very ugly into a greenish or blueish background.
  • add modern rounded corners with transparency.

@DeepDiver1975
Copy link
Member

None of them ever had transparency.

lol - totally missed that. THX

@jnweiger
added transparent round corners to the new icons.
8567700 
drawio.png and richdocuments.png already have transparency.
@jnweiger
Copy link
Contributor Author

jnweiger commented Sep 1, 2023

Transparencies now work in all four:
Here on dark background:
grafik

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jnweiger jnweiger merged commit ac4f338 into release-10.13.1 Sep 1, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the improve-images branch September 1, 2023 14:03
jnweiger added a commit that referenced this pull request Sep 11, 2023
@phil-davis @jnweiger @DeepDiver1975
Merge back Release 10.13.1 (#40975)
930a72a 
* prepare 10.13.1
branched from master,
 - taking 5 small well understood easily testable fixes (for php8 forward compatibility)
 - but before #40961 gets merged to master.

* Improve images (#40963)

* Revamped the onlyoffice.png in gimp: cleaner and smaller PNG, ugly checkerboard background removed. (It was actually a 200k jpeg)
Replaced wopi.png with the logo found at github.com/OfficeDev/PnP-WOPI (it was a copy of the onlyoffic jpeg)

* added transparent round corners to the new icons.
drawio.png and richdocuments.png already have transparency.

* fix: disallow pre-signed url access if the signing key is not initialized

* bump Changelog

* bump version.php for final

* prepare merge back.

* prepare merge back, using 10.13.2 prealpha ...

---------

Co-authored-by: Juergen Weigert <jnweiger@gmail.com>
Co-authored-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnweiger @DeepDiver1975 @phil-davis