Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for existence of creation time when running migrations #40991

Merged
merged 3 commits into from Sep 22, 2023
Merged

Check for existence of creation time when running migrations #40991

merged 3 commits into from Sep 22, 2023

Conversation

pako81
Copy link
Contributor

@pako81 pako81 commented Sep 22, 2023 •
edited

Description

In some weird scenarios it can happen that the migration responsible for adding the creation time in the oc_accounts table is not correctly inserted into oc_migrations with the consequence that it is reattempted when i.e. upgrading apps, even if the column is already present.

Related Issue

Motivation and Context

Make migration more robust.

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@pako81 pako81 added this to the development milestone Sep 22, 2023
@pako81 pako81 self-assigned this Sep 22, 2023
@update-docs
Copy link

update-docs bot commented Sep 22, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pako81 pako81 mentioned this pull request Sep 22, 2023
Closed
5 tasks
@pako81 pako81 force-pushed the migrations_check_for_creation_time branch from 03a3143 to fdf4aa8 Compare September 22, 2023 17:49
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pako81 pako81 merged commit 40c888b into master Sep 22, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the migrations_check_for_creation_time branch September 22, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

@jnweiger jnweiger Awaiting requested review from jnweiger

Assignees

@pako81 pako81

Labels
3 - To Review
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pako81 @IljaN