fix: right after loading windows.oc_user is stored in OC._user - #41054
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
fix/js-dont-store-user-in-global-namespace
branch
from
October 20, 2023 15:30
c56e19d to
9322efc
Compare
jvillafanez
approved these changes
Oct 27, 2023
DeepDiver1975
force-pushed
the
fix/js-dont-store-user-in-global-namespace
branch
from
October 27, 2023 10:18
9322efc to
403c14b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
Bot
deleted the
fix/js-dont-store-user-in-global-namespace
branch
October 27, 2023 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Instead of using
window.oc_userit's value is stored asOC._userThis should prevent to loose this information on Safari where variables in window.* get lost
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: