Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: right after loading windows.oc_user is stored in OC._user #41054

Merged
merged 1 commit into from Oct 27, 2023
Merged

fix: right after loading windows.oc_user is stored in OC._user #41054

merged 1 commit into from Oct 27, 2023

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 20, 2023 •
edited

Description

Instead of using window.oc_user it's value is stored as OC._user

This should prevent to loose this information on Safari where variables in window.* get lost

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Oct 20, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/js-dont-store-user-in-global-namespace branch from c56e19d to 9322efc Compare October 20, 2023 15:30
@mmattel mmattel requested a review from pako81 October 27, 2023 09:26
@DeepDiver1975 DeepDiver1975 force-pushed the fix/js-dont-store-user-in-global-namespace branch from 9322efc to 403c14b Compare October 27, 2023 10:18
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@DeepDiver1975 DeepDiver1975 merged commit f0e4d9a into master Oct 27, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/js-dont-store-user-in-global-namespace branch October 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@pako81 pako81 Awaiting requested review from pako81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeepDiver1975 @jvillafanez