Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper error handling when deleting users/groups is failing #41077

Merged
merged 1 commit into from Nov 8, 2023
Merged

fix: proper error handling when deleting users/groups is failing #41077

merged 1 commit into from Nov 8, 2023

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Nov 8, 2023 •
edited

Description

In case of an error when deleting a user or a group no proper feedback was given to the user.

Bonus: fix undo on groups

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs Update Docs
Copy link

update-docs bot commented Nov 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/js-dont-store-user-in-global-namespace branch from eebc23c to bda43ea Compare November 8, 2023 11:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@jvillafanez jvillafanez mentioned this pull request Nov 8, 2023
Open
@jvillafanez
Copy link
Member

Found #41079 , but I don't think it's caused by this PR. We can fix it in a different PR. Other than that, the code looks fine to me.

@DeepDiver1975
Copy link
Member Author

We can fix it in a different PR.

Reads like this needs to be fixed in some related but still untouched code segment. We can do a dedicated pr ...

@DeepDiver1975 DeepDiver1975 merged commit ba2d7ba into master Nov 8, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/js-dont-store-user-in-global-namespace branch November 8, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When I try to delete a user as admin I get JavaScript error in Chrome
2 participants
@DeepDiver1975 @jvillafanez