fix: account terms can be removed if they differ with the ones stored

[jvillafanez]

Description

Search terms for the accounts were only updated if new terms were present. However, if terms were removed, we weren't updating the terms.

Related Issue

No opened issue

Motivation and Context

How Has This Been Tested?

1. Install and configure the user_ldap app (consider default configuration)
2. Sync the ldap users
3. Change the "user search attributes" in the ldap wizard and add some attributes (at least 2)
4. Sync the ldap users again. Note that terms are populated in the "oc_account_terms" table
5. Remove one of the attributes in the "user search attributes"
6. Sync the ldap users

Without this patch, the "oc_account_terms" won't change, so the removed attribute can still be searched. With the patch, the table is updated

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[pako81]

@jvillafanez merge or should we ask for a second review?

[phil-davis]

Is it easy to add a test that covers this?

[jvillafanez]

Is it easy to add a test that covers this?

If there aren't already tests for the class, I doubt it's easy

@jvillafanez merge or should we ask for a second review?

Good to merge from my side.

[phil-davis]

If there aren't already tests for the class, I doubt it's easy

Sadly, lib/private/User/Account.php does not have any unit tests.