fix: user:list -a command now correctly displays user's creation time

[pako81]

Description

The user:list -a occ command now correctly displays user's creation time.

Motivation and Context

User's creation time was not correctly returned when using the -a key.

How Has This Been Tested?

Manually. Before:

sudo -u www-data php occ user:list -a creationTime
  - admin: /var/www/html/owncloud10133/data/admin
  - user1: /var/www/html/owncloud10133/data/user1
  - user2: /var/www/html/owncloud10133/data/user2
  - user3: /var/www/html/owncloud10133/data/user3

After:

sudo -u www-data php occ user:list -a creationTime
  - admin: 1700847050
  - user1: 1700847086
  - user2: 1701083934
  - user3: 1701083990

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised
• Changelog item

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[jvillafanez]

Side note: we should probably show the date with a standard format.

[pako81]

Side note: we should probably show the date with a standard format.

Should we not rather stay consistent with the lastLogin attribute which is also reported in timestamp format?

Another possibility would be to also convert lastLogin but in this case we need to consider the case where it is set to 0 (user has not performed the first login yet) which otherwise would be converted to January 1, 1970 when using the formatDateTime method.

[phil-davis]

$ php occ user:list -s
...
  - harry:
    - uid: harry
    - displayName: harry
    - email: harrydavis@example.com
    - quota: default
    - enabled: true
    - lastLogin: 1689843012
    - creationTime: 0
    - home: /home/phil/git/owncloud/core/data/harry
    - backend: Database
    - cloudId: harry@localhost
    - searchTerms:
...
  - user1:
    - uid: user1
    - displayName: user1
    - email
    - quota: default
    - enabled: true
    - lastLogin: 1679373156
    - creationTime: 1679372958
    - home: /home/phil/git/owncloud/core/data/user1
    - backend: Database
    - cloudId: user1@localhost
    - searchTerms:

creationTime is already reported in the full listing as a Unix timestamp number. I have some older users that have a zero creation time (that is from the past before this attribute was recorded). So adjusting the output format of login time and creation time is a separate issue - if someone thinks that there is a requirement/need for that.