Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decommission apps templateeditor and extract #41168

Merged
merged 1 commit into from Feb 1, 2024
Merged

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 force-pushed the fix/block-apps branch 2 times, most recently from ab40f54 to 448448f Compare January 31, 2024 07:44
@DeepDiver1975 DeepDiver1975 changed the title fix: decomission apps templateeditor and extract fix: decommission apps templateeditor and extract Jan 31, 2024
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeepDiver1975
Copy link
Member Author

failed acceptance tests are due to timeout afaik ....

@owncloud owncloud deleted a comment from update-docs bot Feb 1, 2024
@phil-davis
Copy link
Contributor

failed acceptance tests are due to timeout afaik ....

agree, but I restarted CI anyway, to be sure that all pipelines will pass.

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

23.5% Coverage on New Code (required ≥ 53%)

See analysis details on SonarCloud

@phil-davis phil-davis merged commit e805fe7 into master Feb 1, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/block-apps branch February 1, 2024 08:07
@DeepDiver1975
Copy link
Member Author

THX

@prsnbrg
Copy link
Contributor

prsnbrg commented Feb 2, 2024

@DeepDiver1975 @phil-davis
Please revert this decision for the "extract" app. I have just published an update for the app in the Marketplace.

@DeepDiver1975
Copy link
Member Author

@prsnbrg under which name did you publish the app on the marketplace? I could not find it. THX

@prsnbrg
Copy link
Contributor

prsnbrg commented Feb 4, 2024

@DeepDiver1975 the update of the app is "published" under the same name as before (extract).
In the Marketplace the status of the app is "blocked". Can this be reverted or does the app have to be published under a new name?

@DeepDiver1975
Copy link
Member Author

@IljaN

@DeepDiver1975
Copy link
Member Author

Thx @prsnbrg
Can you link the GitHub repo as well please?

@prsnbrg
Copy link
Contributor

prsnbrg commented Feb 4, 2024

Sure!
The official repo of this app is: https://github.com/PaulLereverend/NextcloudExtract.
I create a fork for the owncloud app version (is aligned with Paul Lereverend): https://github.com/prsnbrg/NextcloudExtract.

At the moment info.xml is linked to the repo from Paul Lereverend. My plan is to change this in the next few weeks with the next update.

@DeepDiver1975
Copy link
Member Author

@prsnbrg I was rethinking the whole situation.
I suggest you publish the app under a different name.

Why? You have no access the the existing app in marketplace. And regaining this ist just too complicated.

What do you think? Thx a lot

@prsnbrg
Copy link
Contributor

prsnbrg commented Feb 6, 2024

@DeepDiver1975
Sorry for the confusion.
I have already published the first version of the app on Marketplace. However, since the app works perfectly for me and therefore the updates are somewhat neglected, which will not happen again in the near future.
It would be great if the app that was blocked in the Marketplace by ownCloud could be published again and the change in this PR reverted.

@IljaN
Copy link
Member

IljaN commented Feb 7, 2024

@prsnbrg @DeepDiver1975 Unblocked the extract app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants