Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result scrollbar #4259

Merged
merged 2 commits into from
Jul 31, 2013
Merged

Search result scrollbar #4259

merged 2 commits into from
Jul 31, 2013

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 31, 2013

add vertical scrollbar on search result overflow, em -> px properties, whitespace cleanup
fixes #4236, a piece of #4248
@jancborchardt @VicDeo @DeepDiver1975 @kabum @karlitschek

This was referenced Jul 31, 2013
padding:.2em;
}
.ie8 #searchresults {
border: 1px solid #666 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid this !important?
.ie8 #searchresults is actually more specific then just #searchresults

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not add IE8 related css tweaking to this PR. I only fixed the whitespace. Feel free to create a PR and @ mention me for testing.

@ghost
Copy link

ghost commented Jul 31, 2013

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/288/

@Niduroki
Copy link
Member

👍 tested in Chromium 30.0.1575.0 and Firefox 22.0

@MorrisJobke
Copy link
Contributor

👍 Tested in Chromium 28, FF 22, IE9

MorrisJobke added a commit that referenced this pull request Jul 31, 2013
@MorrisJobke MorrisJobke merged commit 563c63b into master Jul 31, 2013
@MorrisJobke MorrisJobke deleted the search_result_scrollbar branch July 31, 2013 20:03
@karlitschek
Copy link
Contributor

@butonic Can you backport?

@Niduroki
Copy link
Member

Niduroki commented Aug 1, 2013

@karlitschek #4260 :)

@karlitschek
Copy link
Contributor

Yay :-)

@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long search results are not fully displayed due to missing scrollbar; Ticket#2013072508000607
5 participants