Continuing the New User management

[raghunayyar]

🚧 PR just for collaborating. Work In Progress, don't click merge yet.

First priority, basic functionality

• the settings area should slide out smoothly, like in News. Also it should be possible to close it again by clicking on the same header area. And the header shouldn’t have a different color than the drawer. Best just try to extract it out from News and transfer the styles to core.
• Search filter needs to rely on server response, because not necessarily all users are already in the list (by @blizzz )
• the undo notification should disappear after 7 seconds and perform the the delete operation (by @DeepDiver1975 / @jancborchardt )
• creating a group on the drop down menu dies not update the group list on the left (by @DeepDiver1975 )
• creating a group on the group panel does not update the list (by @DeepDiver1975 )
• delete of group does not trigger delete on the server (by @DeepDiver1975 )
• adding a group should not be an input and button right away, but rather work like adding Groups in the Contacts app (inserting a new entry below) (by @jancborchardt)
• the clickable area of the group actions (rename, delete) needs to be the whole row height and width of 44px
• the rename button should be directly next to the name, just like in the Files app
• the rename and delete icons should show half-transparent, and only dark on hover – maybe only use the .action class, just like Files and News do
• create users fails with: Fatal error: Call to undefined method OCP\JSON::checkSubAdminUser() in /home/blizzz/owncloud/dev/master/settings/ajax/createuser.php on line 4 (by @blizzz)
• filtering users oftentimes does not work, filtering admins almost never works (shows more people) (by @jancborchardt )
• we need a spinner as feedback when switching groups (by @jancborchardt )
• when a group is selected/shown, mark the entry in the sidebar as active. Just like in Notes. (by @jancborchardt )
• The delete group action should only show up for the currently active group. That is, not on hover. (by @jancborchardt )
• The »Create« buttons have too big of a font-size (18.33 px, cause of 0.8 em of the body) (by @jancborchardt )
• »admin« is a set group, it shouldn’t be possible to delete (right @DeepDiver1975?) (by @jancborchardt )
• In addition to deletion, we need a »rename« action on the group (by @jancborchardt )
• We need search in form of a filter (by @jancborchardt )
• selecting a group on the group panel does not update the user list (by @DeepDiver1975 )
• rename Storage to Quota (by @blizzz)
• groups should be sorted by number of people in them, not by alphabet (by @jancborchardt)
• groups with no members should have no number, instead of a 0 (by @jancborchardt)
• the sidebar should be position: fixed so it doesn’t move around when scrolling (should be in the core styles) (by @jancborchardt)
• the app-navigation needs a higher z-index than the content, so that the content does not overlap the sidebar when you scroll horizontally (should be in the core styles, by @jancborchardt)
• the »Create« button should say »Add user« to be more specific (by @jancborchardt)
• the settings area should be a slide-out drawer like in the News app (by @jancborchardt)
• What shall happen when clicking on a filtered group? – Show all users of that group, but show those first which also match the filter term. Maybe with a divider below. (by @blizzz )
• Click on Everybody: No, it should display »Everybody« but filtered by the filter. Only resetting the filter should reset the filter. (by @blizzz )
• To reset filter: »clickable x icon in the filter box to empty the filter«(by @blizzz )

Additional features

• should be usable to manage huge amount of users (>20k) (by @blizzz )
• pre-defined filters: Everyone, Users by Backend (Internal, LDAP, etc.), Not Grouped (users without group), Disabled Users. They shall be shown only if they contain rows, and be post-loaded using Ajax (by @blizzz )
• Last Login requires core to store last login/session refresh (by @blizzz )
• column for email (after Full Name), lets admin edit the email (by @blizzz )
• optional columns (to activate by checkbox on the bottom left): Usage (displays Quota usage in %, after Quota), followed by Storage Location, Last Login (last col). Choice of which are displayed should be remembered (by @blizzz )
• checkbox to send email to users after creation of the account (by @blizzz )
• when encryption app is enabled and a recovery key is available: on password change ask for recovery key by prompt so that files are recovered. see current implementation as example on how it works. (by @blizzz \cc @schiesbn )

Big features which have to wait first

• multiselect and edit of users (as in Files or Contacts-master app) (by @blizzz )
• option to disable internal users (by @blizzz )
• sortable columns (by @blizzz )

[raghunayyar]

@jancborchardt here we go. ;)

[jancborchardt]

@DeepDiver1975 @Raydiation @PVince81 check this out.

cc @owncloud/designers @MTRichards as well.

[jancborchardt]

Good one @raghunayyar!

Feedback:

• The delete group action should only show up for the currently active group.
• The »Create« buttons have too big of a font-size (18.33 px, cause of 0.8 em of the body)
• »admin« is a set group, it shouldn’t be possible to delete (right @DeepDiver1975?)

Additional features:

• In addition to deletion, we need a »rename« action on the group
• We need search in form of a filter
• We need an email input field

[karlitschek]

We have the additional request to do "user defined groups" any idea here?

[jancborchardt]

@karlitschek what does that mean exactly? Is there a writeup or issue on that?

@raghunayyar we should change »Storage« to »Quota« to prevent misunderstanding. Can you do that?

[karlitschek]

@jancborchardt Not clear yet. Needs to be defined

[DeepDiver1975]

The inspection completed: 5 new/changed issues

@raghunayyar please have a look at the scrutinizer inspection - it's worth having a look 😉

[DeepDiver1975]

Wow - what's that?

this could be added as a data-attribute and accessed by jquery - no need for a dynamically generated javascript file

[raghunayyar]

@DeepDiver1975 pre-exisitng, I didn't do that. Checking it though. thx!

[DeepDiver1975]

@raghunayyar did you test this? 😉

Uncaught SyntaxError: Unexpected token } users.js:601

[DeepDiver1975]

Is search supposed to work?

I have a strange scroll behavior:
the group panel and the user list can be scrolled on few pixels up/down - no matter how big the window is

[raghunayyar]

@DeepDiver1975 it's an initial commit. I too am getting issues. Will definitely fix it this morning.

[MTRichards]

The way it was explained to me:
As a user, I want to be able to log into ownCloud and share files with others. I also want to be able to create my own, private, user defined groups so that it is easier for me to share files quickly with an ad-hoc group of my peers.

Acceptance Criteria:

• User can easily create user defined groups for their use
• User can share files and folders with user defined groups the same was as with ownCloud defined users and groups
• User can manage (rename, add, remove) their user defined groups
• Other users cannot see the user defined groups

At least at a high level, that is what folks have explained to me.

[DeepDiver1975]

@MTRichards these groups are supposed to be used for sharing only? In addition these groups seem to be user specific - e.g. my group named 'family' will contain a different set of user compared to a different user.

Shall this group contain ownCloud users only or shall emails for public/pin-protected sharing be included as well?

I guess we can move this to the sharing next generation ticket - right?

[MTRichards]

@MTRichards these groups are supposed to be used for sharing only? In addition these groups seem to be user specific - e.g. my group named 'family' will contain a different set of user compared to a different user.

Yes and Yes!

Shall this group contain ownCloud users only or shall emails for public/pin-protected sharing be included as well?

From a user perspective, a group should be able to be a list of users, groups, or email addresses. It is just a shortcut when sharing a lot of the same files with people all the time.

I guess we can move this to the sharing next generation ticket - right?

Absolutely, but I think this is a tad lower on the list than a lot of the sharing elements we need.

[sfabel]

+1 on this feature - this would be useful for enterprise customers as well, trying to establish collaboration projects outside of the existing directory backend.

[raghunayyar]

@DeepDiver1975 forced pushed the correction typos and the syntax errors along with the Initial Search Commit just now. Looking it into Scrutinizer now ;)

[raghunayyar]

@jancborchardt do you want to give an option of adding the email ID while a user is created? I mean, three inputs. Username, Password and Email ID. Or is there something I am missing here. Please explain! thanks!

[DeepDiver1975]

@jancborchardt do you want to give an option of adding the email ID while a user is created? I mean, three inputs. Username, Password and Email ID. Or is there something I am missing here. Please explain! thanks!

email is not mandatory at the moment - and we shall keep this constraint.

[jancborchardt]

Even though the email is not mandatory, I would introduce that field in the "adding a user" row. Password and groups are optional as well. But email is important for lots of communication, notification, password reset etc.

Just have the placeholder say "Email (optional)".

[raghunayyar]

@jancborchardt @DeepDiver1975 can you guys test the search behaviour now? @kabum helped me fix it. ;)

[heavymanto]

hi, I'd like to have two new features

1. a checkbox to enable / disable user
2. Be able to set up the email of the user already created

thanks

[raghunayyar]

@heavymanto lets do the MVP first please! I am sure the features you suggested will be followed by.

[DeepDiver1975]

I have a strange scroll behavior:
the group panel and the user list can be scrolled on few pixels up/down - no matter how big the window is

@raghunayyar @jancborchardt this scrolling issue is still there

[scrutinizer-notifier]

A new inspection was created.

[scrutinizer-notifier]

The inspection completed: 57 new issues, 9 updated code elements

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5196/

[blizzz]

Ladies & Gentlemen, let's get this reviewed and merged. Remaining tasks from #7151 (comment) will be dealt with as bugs.

[karlitschek]

looks good to me 👍

[karlitschek]

Who can help to merge this? @PVince81 @DeepDiver1975 @MTRichards ?

[scrutinizer-notifier]

A new inspection was created.

[schiessle]

Tested recovery key functionality for encryption, works as expected... For this part 👍 Also otherwise it looks good, I didn't looked a the code.

[schiessle]

Just a minor thing, why does the quote drop-down looks different then the other drop-downs?

[blizzz]

The other ones are jquery ui multi-select dropdowns, does not differ to 6.

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/5208/

[DeepDiver1975]

👍 🚀 👯

[MorrisJobke]

👏

[vgezer]

Can we remove groups now? I remember seeing it 2 days ago, but now I cannot.

[blizzz]

It was implemented, maybe cleanup or rebase killed it… can you open a new issue for it, please?

[juhulian]

It would be nice to have a monitor mode for user storage...

[jancborchardt]

@juhulian please instead of commenting on a long solved pull request open a new issue. :) In there also explain more in detail what you mean. Thanks

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.