-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile sidebar swipe #8159
Mobile sidebar swipe #8159
Conversation
@jbtbnl for contacts it seems to be this commit owncloud/contacts@0382cee |
@jbtbnl I’d be very interested what you think about how to do the sidebar right. I think we do need to position that and the content absolutely. The question is, should we use a fixed 250px width, or percentage? I’d also be cool with fixed, but what do you think about the percentage? |
@jancborchardt how did you test the swipe gesture? I'm testing it with Google Chrome device emulation but it won't work... Edit: works on my BB Q10. |
@jancborchardt af few feedback points:
Disclaimer: I do realize that it's not an easy job to implement the above mentioned :) |
Looks pretty good so far! |
@jbtbnl good concepts! I really wonder about the combined sidebar vs the separated one:
And if we don’t make it combined, it would be confusing to have the sidebar be full height because that makes it seem global. It’s not though. It’s just a view on an app, and some apps are not going to need it either. (Also, in the mockups, make sure to not miss the ownCloud logo and the user menu. ;) |
@jbtbnl btw I would really like to have a call with you about that. Do you use Skype, or wanna use http://talky.io or whatnot? I’m busy until Sunday but Monday would work. (We can talk about it on IRC.) |
@jancborchardt yeah, I forgot about the user menu, the ownCloud logo not so much :) |
Please make sure to also test opening files, for example with the text editor: it will auto-hide the sidebar to display itself fullscreen (since the sidebar PR). I guess it should still work with your approach, but better be sure 😄 |
Updated, please test this out on mobile and desktop @owncloud/designers! |
I have 3 remarks/questions:
|
💣 Test Failed. 💣 |
@LEDfan yes, I think that is the desired behavior. |
One thing which still needs to be fixed: The content is swipable to the right even when you are not in mobile mode. This results in big whitespace. @MorrisJobke @jbtbnl could you check if you can fix that? Maybe we need to wrap the snap.js part in js.js in a media query. Or disable something in the call to snap.js |
💣 Test Failed. 💣 |
@jancborchardt there still are major compatibility issues with all apps and the performance is terrible. I understand that you want to push this before the feature freeze but in this state it hardly fixes anything... |
I fixed the problem with wider screens (now it's just activated for small screens (< 768px) |
💣 Test Failed. 💣 |
The inspection completed: 22 new issues |
|
|
A new inspection was created. |
👍 |
Ok, changes by you look good as well @PVince81 👍 |
JS tests run locally |
@jancborchardt Also document this!!! Otherwise it will just be lost and only used in some apps |
💣 Test Failed. 💣 |
failing unit tests are unrelated -> merge |
@@ -1131,6 +1131,60 @@ function initCore() { | |||
} | |||
|
|||
setupMainMenu(); | |||
|
|||
// just add snapper for logged in users | |||
if($('#body-login, #body-public').length === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jancborchardt didn't you change this to #app-navigation
? I remember you did when we were having a look at it.
Either you forgot to push that change or reverted back ?
APP DEVS: If tapping on an element in the app-navigation switches to the content and you don’t want that (for example if it’s a button or so), use
.app-navigation-noclose
on the highest element in which you do not want taps to close the navigation.Fixing #176
This will make ownCloud usable on mobile again since we introduced sidebars. Specifically this is about having a way to toggle between the sidebar (app-navigation) and content (app-content).
This is done using Snap.js and works via swipe as well as with the button in the top left.
TODO: