Add ability to enable/disable maintenance mode from cli. #8748
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| <?php | ||
| /** | ||
| * Copyright (c) 2013 Robin Appelman <icewind@owncloud.com> | ||
| * and Stephen Colebrook <scolebrook@mac.com> | ||
| * This file is licensed under the Affero General Public License version 3 or | ||
| * later. | ||
| * See the COPYING-README file. | ||
| */ | ||
|
|
||
| namespace OC\Core\Command\Maintenance; | ||
|
|
||
| use Symfony\Component\Console\Command\Command; | ||
| use Symfony\Component\Console\Input\InputInterface; | ||
| use Symfony\Component\Console\Input\InputOption; | ||
| use Symfony\Component\Console\Output\OutputInterface; | ||
|
|
||
| class Mode extends Command { | ||
|
|
||
| protected function configure() { | ||
| $this | ||
| ->setName('maintenance:mode') | ||
| ->setDescription('set maintenance mode') | ||
| ->addOption( | ||
| 'on', | ||
| null, | ||
| InputOption::VALUE_NONE, | ||
| 'enable maintenance mode' | ||
| ) | ||
| ->addOption( | ||
| 'off', | ||
| null, | ||
| InputOption::VALUE_NONE, | ||
| 'disable maintenance mode' | ||
| ); | ||
| } | ||
|
|
||
| protected function execute(InputInterface $input, OutputInterface $output) { | ||
| if ($input->getOption('on')) { | ||
| \OC_Config::setValue('maintenance', true); | ||
| $output->writeln('Maintenance mode enabled'); | ||
| } elseif ($input->getOption('off')) { | ||
| \OC_Config::setValue('maintenance', false); | ||
| $output->writeln('Maintenance mode disabled'); | ||
| } else { | ||
| if (\OC_Config::getValue('maintenance', false)) { | ||
|
There was a problem hiding this comment. Use elseif instead, which is one level less deep. There was a problem hiding this comment. From a computation perspective it doesn't make any difference but I prefer this style. There are three available options, on, off and nothing. In the event of nothing, status is displayed which can have two possible values. So determining and returning that status is nested. Representing the 3 options as 4 parts of the same if block because one of the options can have two return values makes it a little less readable to my mind. |
||
| $output->writeln('Maintenance mode is currently enabled'); | ||
| } else { | ||
| $output->writeln('Maintenance mode is currently disabled'); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2014?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the code was written in 2013 by Robin. This is just a cp of singleuser.php with a handful of changes for the different config option. So I left it. Should it be changed to 2014 or 2013-2014?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another copyright line with 2014 and your name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that you probably copied singleuser.php to mode.php and then swapped all the logic contained in the actually command class, I am not sure there is anything remaining that would have to attributed to robin.