Cleanup Document Preview #9784
Merged
Cleanup Document Preview #9784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the env:UserInstallation flag like https://github.com/owncloud/documents/blob/master/lib/converter.php. This will stop the creating of multiple directories for document conversion in tmpDir.
|
The inspection completed: No new issues |
|
🚀 Test Passed. 🚀 |
|
@georgehrke @VicDeo please review - THX |
|
@VicDeo @georgehrke What do you think? |
|
Looks good from my POV. 👍 |
|
code itself looks good, will test asap |
|
@georgehrke ping? |
|
works 👍 |
|
@LukasReschke please review regarding shell exploit - THX |
|
LGTM 👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Jul 28, 2014
Cleanup Document Preview
|
@karlitschek 7.0.1 relevant? |
|
Yes. Please backport |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the env:UserInstallation flag like https://github.com/owncloud/documents/blob/master/lib/converter.php.
This will stop the creating of multiple directories for document conversion in tmpDir.