Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix owncloud.org history and created a missing file #202

Merged
merged 3 commits into from Nov 6, 2018

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Nov 5, 2018

Link corrections in the page footer:

  • owncloud.org/history is no longer available and there is no replacement for - line deleted
  • other available links pointing to a new name have been corrected

Missing file:

  • release_notes.adoc was missing
    image
    The file contains now a basic content which must be updated on new doc releases.

Fixes: #200 (https://owncloud.org/history is no longer a valid link)

Update:
After digging and drilling why the changes like history did not ave any effect, I found the solution.
If you change any of the .hbs files, you also need to add/replace them in ui-bundle.zip. Only then the changes take effect !

@settermjd @hurradieweltgehtunter

@mmattel mmattel added the bug Something isn't working label Nov 5, 2018
@tboerger
Copy link
Contributor

tboerger commented Nov 6, 2018

The ui bundle should be downloaded from the doc theme repo.

@mmattel
Copy link
Contributor Author

mmattel commented Nov 6, 2018

Just for completeness, ui-bundle.zip cant currently be found neither in docs-themes or docs-ui

@settermjd
Copy link
Contributor

Just for clarity, the ui-bundle.zip isn't tracked in the repo, but one's available as a build artifact with both releases. To see the changes, you need to first rebuild the theme after you make any changes, using gulp pack, then you need to point the docs repo at the newly generated ui-bundle.zip, so that the changes are visible. I didn't track ui-bundle.zip, as it didn't make sense when it's a build artifact (at least it didn't make sense to me).

@settermjd
Copy link
Contributor

I think I need to turn that last comment into a blog post.

@settermjd settermjd merged commit a380e88 into master Nov 6, 2018
@settermjd settermjd deleted the fix_owncloud.org_history branch November 6, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants