New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add broken Xref checker #212
Conversation
7f56b75
to
7058bf0
Compare
--pull \ | ||
--ui-bundle-url https://github.com/owncloud/docs-ui/releases/download/1.1.0/ui-bundle.zip \ | ||
--generator=./generator/xref-validator \ | ||
site.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
site.yml
--> site.prod.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would have to happen later, as that file's not part of this branch. The docs can be updated later.
```console | ||
antora generate \ | ||
--pull \ | ||
--ui-bundle-url https://github.com/owncloud/docs-ui/releases/download/1.1.0/ui-bundle.zip \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reference to the local ui-bundle.zip
not the one from docs/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the release artifact is the right one, for the time being, until the build pipeline is finalised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry disagree. we currently do have regular updates in docs-ui and as long the automated process is not in place, any reference to an old bundle will counteract the updates made. just my 2c
First
with option Second |
7058bf0
to
51cea98
Compare
This generator loads just enough of the Antora process, so that it can check the xref links, to ensure they're valid and nothing further.
51cea98
to
fd4f8e1
Compare
That error shouldn't appear when the Antora packages are installed locally. As #216 is merged to master, and rebased now onto this PR, it should be fine to merge this now. I'll update the README to cover the inclusion of package.json and package-lock.json in a separate PR. |
This PR adds a custom Antora generator script that can find and report broken Xrefs in the documentation and updates the docs to show how to use it.