Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broken Xref checker #212

Merged
merged 2 commits into from Nov 9, 2018
Merged

Add broken Xref checker #212

merged 2 commits into from Nov 9, 2018

Conversation

settermjd
Copy link
Contributor

This PR adds a custom Antora generator script that can find and report broken Xrefs in the documentation and updates the docs to show how to use it.

@settermjd settermjd added enhancement New feature or request review required deployment Tasks relating to deploying the documentation labels Nov 8, 2018
@settermjd settermjd self-assigned this Nov 8, 2018
@settermjd settermjd force-pushed the add-broken-xref-checker branch 2 times, most recently from 7f56b75 to 7058bf0 Compare November 8, 2018 08:41
--pull \
--ui-bundle-url https://github.com/owncloud/docs-ui/releases/download/1.1.0/ui-bundle.zip \
--generator=./generator/xref-validator \
site.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site.yml --> site.prod.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would have to happen later, as that file's not part of this branch. The docs can be updated later.

```console
antora generate \
--pull \
--ui-bundle-url https://github.com/owncloud/docs-ui/releases/download/1.1.0/ui-bundle.zip \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reference to the local ui-bundle.zip not the one from docs/releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the release artifact is the right one, for the time being, until the build pipeline is finalised.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry disagree. we currently do have regular updates in docs-ui and as long the automated process is not in place, any reference to an old bundle will counteract the updates made. just my 2c

@mmattel
Copy link
Contributor

mmattel commented Nov 8, 2018

First
I used that branch to test, but I get the following error

error: Generator not found or failed to load.

with option --stack-trace:
Error: Cannot find module '@antora/content-aggregator'

Second
I created #205 (Have an own page for a broken link checker)
Why not adding it there ? Would make more sense to me as the other once can also check external links.

This generator loads just enough of the Antora process, so that it can
check the xref links, to ensure they're valid and nothing further.
@settermjd
Copy link
Contributor Author

That error shouldn't appear when the Antora packages are installed locally. As #216 is merged to master, and rebased now onto this PR, it should be fine to merge this now. I'll update the README to cover the inclusion of package.json and package-lock.json in a separate PR.

@settermjd settermjd merged commit 5d2a882 into master Nov 9, 2018
@settermjd settermjd deleted the add-broken-xref-checker branch November 9, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Tasks relating to deploying the documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants