Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump asciidoctor-kroki from 0.8.2 to 0.10.0 #2867

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

Bumps asciidoctor-kroki from 0.8.2 to 0.10.0.

Signed-off-by: dependabot-preview[bot] support@dependabot.com

This is a cherry-pick of #2847 because drone CI is not starting on that PR.

@phil-davis
Copy link
Contributor Author

phil-davis commented Nov 18, 2020

There is a release 0.10.0 on GitHub https://github.com/Mogztter/asciidoctor-kroki/releases/tag/v0.10.0
And at https://www.npmjs.com/package/asciidoctor-kroki

But drone CI fails https://drone.owncloud.com/owncloud/docs/8585/1/4

Error: Cannot find module '/drone/src/node_modules/asciidoctor-kroki/dist/node/asciidoctor-kroki.js'

???

@mmattel
Copy link
Contributor

mmattel commented Nov 18, 2020

Opened a issue in: asciidoctor/asciidoctor-kroki#177

snip...
I am investigating a strange issue. Using antora in our ownCloud docs environment, we get errors when trying to upgrade to 0.10.0 because of missing node/asciidoctor-kroki.js. Running:

yarn upgrade asciidoctor-kroki@0.8.2
respectively
yarn upgrade asciidoctor-kroki@0.10.0

Comparing the directories node_modules/asciidoctor-kroki/dist you see an important difference:
0.8.2 --> has subdirectories browser and node
0.10.0 -- has only subdirectory browser...

I am no yarn specialist and hope I am not getting flamed, but this seems strange to me.
snip...

@mmattel
Copy link
Contributor

mmattel commented Nov 19, 2020

I corrected the path in site.yml as stated in the referenced issue to node_modules/asciidoctor-kroki/src/asciidoctor-kroki.js and tested the installation locally with yarn upgrade asciidoctor-kroki@0.10.0 and yarn install. Voila, it works now and I was able to make a docs build successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants