Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-JIS text file broken view #46

Closed
ghost opened this issue Oct 17, 2014 · 3 comments
Closed

Shift-JIS text file broken view #46

ghost opened this issue Oct 17, 2014 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Oct 17, 2014

  1. upload text file that include Japanese character (saving Shift-JIS).
    Using [notepad.exe] etc...
  2. app+ > text editor plugin on
  3. click uploaded text file problem appear.

owncloud.log
{"app":"PHP","message":"iconv(): Detected an illegal character in input string at /var/www/owncloud/apps/search_lucene/3rdparty/Zend/Search/Lucene/Analysis/Analyzer/Common/TextNum.php#58","level":3,"time":"2014-10-17T15:44:46+00:00"}
text_editor_problem

Is this a bug ?

note:
saving UTF-8, this problem away.

@ukitiyan
Copy link

Guessing this is mb_detect_encoding.

It is need to change this string by using variable.

https://github.com/owncloud/files_texteditor/blob/master/ajax/loadfile.php

$encoding = mb_detect_encoding($filecontents."a", "UTF-8, WINDOWS-1252, ISO-8859-15, ISO-8859-1, ASCII", true);

ex)

$encoding = mb_detect_encoding($filecontents."a", "UTF-8, WINDOWS-1252, SJIS-win, ISO-8859-15, ISO-8859-1, ASCII", true);

It is desirable that this setting is changed and is considered to be it.

@ghost
Copy link
Author

ghost commented Nov 11, 2015

I’m closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on for so long, then it seems no one has the time to implement this.

Please reopen if you still encounter this issue with the latest stable version and then please use the issue template. You can also contribute directly by providing a patch – see the developer manual. :)

Thank you!

@ghost ghost closed this as completed Nov 11, 2015
@ghost
Copy link
Author

ghost commented May 30, 2016

Production Channel ownCloud 8.2.3 (stable) still have this issue.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants