Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use firebase/php-jwt from core #401

Merged
merged 2 commits into from Aug 8, 2023
Merged

fix: use firebase/php-jwt from core #401

merged 2 commits into from Aug 8, 2023

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 3, 2023 •
edited

@DeepDiver1975 DeepDiver1975 mentioned this pull request Aug 3, 2023
Merged
11 tasks
phil-davis
phil-davis reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs PR #400 merged-back first, then rebase this.

composer.json Show resolved Hide resolved
@SwikritiT SwikritiT mentioned this pull request Aug 4, 2023
Closed
@phil-davis
Copy link
Contributor

@DeepDiver1975 PR #400 has been merged. This can be rebased, conflicts resolved etc.

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975 PR #400 has been merged. This can be rebased, conflicts resolved etc.

I am OOTO the next weeks - please take over - THX

@phil-davis phil-davis self-assigned this Aug 8, 2023
@phil-davis
Copy link
Contributor

I adjusted the acceptance tests so that they are only run against core master, which is 10.13.
We know that this does not work with core 10.12

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 6d7e9c2 into master Aug 8, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/jwt-dependency branch August 8, 2023 10:54
@phil-davis phil-davis mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@phil-davis phil-davis

Labels
3 - To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeepDiver1975 @phil-davis