Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require firebase/php-jwt in core and all apps can use it #40901

Merged
merged 2 commits into from Aug 3, 2023

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 3, 2023

Description

Sort out dependency hell for firebase/php-jwt

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Aug 3, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review August 3, 2023 10:33
@DeepDiver1975 DeepDiver1975 changed the title Fix/jwt dependency fix: require firebase/php-jwt in core and all apps can use it Aug 3, 2023
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Changelog?

@jnweiger
Copy link
Contributor

jnweiger commented Aug 3, 2023

Do we have backwards compat issues to keep in mind?
Should we bump minversion to 10.13 in texteditor and wopi for this?

@phil-davis
Copy link
Contributor

Should we bump minversion to 10.13 in texteditor and wopi for this?

yes - https://github.com/owncloud/wopi/pull/254#issuecomment-1663752003

@DeepDiver1975
Copy link
Member Author

will take care ...

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DeepDiver1975
Copy link
Member Author

version on texteditor and wopi was been adjusted

@phil-davis phil-davis merged commit 027a1a5 into master Aug 3, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/jwt-dependency branch August 3, 2023 14:40
@phil-davis
Copy link
Contributor

Merged so that this will get into the core daily tarball tonight. Then the fles_texteditor and wopi CI will run with that core, and we will see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants