-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: require firebase/php-jwt
in core and all apps can use it
#40901
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
firebase/php-jwt
in core and all apps can use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog?
Do we have backwards compat issues to keep in mind? |
yes - https://github.com/owncloud/wopi/pull/254#issuecomment-1663752003 |
will take care ... |
4ececd0
to
92de25d
Compare
Kudos, SonarCloud Quality Gate passed! |
version on texteditor and wopi was been adjusted |
Merged so that this will get into the core daily tarball tonight. Then the fles_texteditor and wopi CI will run with that core, and we will see what happens. |
Description
Sort out dependency hell for
firebase/php-jwt
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: