Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] 11.2.4.7 Focus visible #1338

Closed
3 tasks done
tschiebel opened this issue Apr 5, 2024 · 1 comment · Fixed by #1349
Closed
3 tasks done

[a11y] 11.2.4.7 Focus visible #1338

tschiebel opened this issue Apr 5, 2024 · 1 comment · Fixed by #1349
Assignees
@felix-schwarz
Labels
Accessibility p3-medium Normal priority Type:bug Something isn't working
Milestone
12.3-Next

Comments

@tschiebel
Copy link

tschiebel commented Apr 5, 2024 •
edited by felix-schwarz
Loading

audit: https://infinite.owncloud.com/s/qSvYucPltEYUhhc

https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de
https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf

Note: If the focus highlighting is done exclusively by a color change,
the contrast between the focused and unfocused state should be sufficient.
It is recommended that the contrast ratio is at least 3:1.

Personal Space

  • For all buttons where the keyboard focus has been implemented by changing the background
    background color, the keyboard focus is difficult to see. The
    contrast between the focused and unfocused state is significantly below the recommended
    the recommended contrast ratio of 3:1.
    image

Fix: When focused, the secondary information row now uses the same color as the primary information row, providing better contrast:
Bildschirmfoto 2024-05-22 um 22 47 40
The background color itself can't be changed as it is system-provided and used with the same contrast across the entire operating system.

Menu, Shared with me, Shared with others

  • See commentary on Personal Space.

Spaces

  • The space buttons have a barely visible keyboard focus.
    image
@tschiebel tschiebel added Type:bug Something isn't working p3-medium Normal priority Accessibility labels Apr 5, 2024
@TheOneRing TheOneRing added this to the 12.3-Next milestone May 21, 2024
@felix-schwarz felix-schwarz self-assigned this May 21, 2024
@felix-schwarz felix-schwarz mentioned this issue May 21, 2024
Merged
3 tasks
felix-schwarz added a commit that referenced this issue May 22, 2024
@felix-schwarz
- ActionCell: direct keyboard focus to embedded buttons, allowing to …
d3cd5d4 
…reach them via the keyboard (similar to issue in #1336)

- DriveHeaderCell: replace hardcoded background color for darkBackgroundView with new "semicover" CSS selector and ThemeCSSView
- DriveGridCell: dynamically change CSS selectors based on focused state and trigger color updates (enabling fix for #1338)
- SavedSearchCell: make side button actions (typically "Add to sidebar") accessible as custom accessibility action
- UniversalItemListCell: reflect .isFocused state changes in the CSS selectors of the primary and secondary detail views
- ComposedMessageView: opt-out of keyboard focus (see #1337)
- OCAction+UIAction: add method to derive a UIAccessibilityCustomAction from an OCAction
- SegmentView: re-create and layout item views if CSS selectors change
- ThemeCSS: add new .focused selector
- ThemeCollection: add new records for focused state of UniversalItemListCell (to fix contrast of secondary line, see #1338) and drive grid cell (to clearly distinguish focused and unfocused states, see #1338)
@felix-schwarz felix-schwarz linked a pull request May 23, 2024 that will close this issue
[fix/a11y] Fix accessibility issues #1349
Merged
3 tasks
@jesmrec
Copy link
Contributor

jesmrec commented May 29, 2024

Everything fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felix-schwarz felix-schwarz

Labels
Accessibility p3-medium Normal priority Type:bug Something isn't working
Projects
None yet
Milestone
12.3-Next
Development

Successfully merging a pull request may close this issue.

[fix/a11y] Fix accessibility issues owncloud/ios-app
4 participants
@TheOneRing @felix-schwarz @jesmrec @tschiebel