Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milestone/11.10.0] Milestone 11.10.0 #1117

Merged
merged 14 commits into from May 17, 2022
Merged

[milestone/11.10.0] Milestone 11.10.0 #1117

merged 14 commits into from May 17, 2022

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Apr 6, 2022

Description

  • Build with iOS 15 SDK
  • Bugfixes

Related Issue

#1124

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

QA

Reports:

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ hosy
❌ Matthias Hühne
❌ felix-schwarz


Matthias Hühne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

hosy and others added 3 commits April 8, 2022 16:07
* - migrated code to new OpenSSL 1.1.1 API
- using OpenSSL Package

* - update SDK

* - update ios-sdk

Co-authored-by: Matthias Hühne <>
Co-authored-by: Felix Schwarz <fs-git@iospirit.com>
…r, when running shortcut intents (could not read app bundle identifier in extension) (#1122)

Co-authored-by: Matthias Hühne <>
* #1066 support for iOS 15 SDK: Solving UI issues, removing unneeded code

* - updated Xcode version for fastlane
- fastlane readme update

Co-authored-by: Matthias Hühne <>
@hosy hosy self-assigned this May 4, 2022
@hosy hosy added this to the 11.10.0-Current milestone May 4, 2022
hosy and others added 2 commits May 9, 2022 09:29
…e Account Item", because of wrong intent configuration (#1125)

Co-authored-by: Matthias Hühne <>
* - update SDK for improved error handling
- add environment variable switch to enable/disable action-timeout-simulator host simulator

* - update SDK with changes addressing code review findings by @hosy in #1119
@jesmrec
Copy link
Contributor

jesmrec commented May 9, 2022

(1) [FIXED]

Sometimes when browsing back, there is a small glitch showing the Empty folder for a while and then loading the list. Check the following video out. It does not happen every time but it is frequently visible:

RPReplay_Final1652098302.MP4

iPhoneXR v15.4
94be4380

Matthias Hühne added 2 commits May 9, 2022 15:25
- added in-app release notes
- changed app version number
- removed beta build warning
@jesmrec
Copy link
Contributor

jesmrec commented May 10, 2022

(2)

Another small glitch. Thumbnails blink when browsing into a folder. In the following video, this effect could be appreciated but it's more visible with a real device:

RPReplay_Final1652170614.MP4

iPhoneXR iOS15.4
22321040

@jesmrec jesmrec linked an issue May 10, 2022 that may be closed by this pull request
34 tasks
@jesmrec
Copy link
Contributor

jesmrec commented May 16, 2022

(3) [WONT FIX HERE]

this is also server related, so we'll maybe need some collaboration from there

App does not connect the latest ocis version (2.0.0). This is how status.php looks like in the test instances:

{
    "installed": true,
    "maintenance": false,
    "needsDbUpgrade": false,
    "version": "2.0.0.0",
    "versionstring": "2.0.0-beta1",
    "edition": "Community",
    "productname": "Infinite Scale",
    "product": "Infinite Scale"
}

So, by typing ocis.owncloud.com or ocis.owncloud.works , an error happens:

Screenshot 2022-05-16 at 09 30 39

because the minimum oC classic server version is 10, and oCIS is 2... 2 lower that 10, therefore error comes. Should the fields product and/or productname be taken in account to the version checks?

iPhoneXR v15.4.1
fbf68cc6

Also reproducible in Android.

… and showing empty folder message (QA finding 1, 2)
@hosy
Copy link
Collaborator Author

hosy commented May 16, 2022

@jesmrec (1), (2) should be fixed with the latest commit

@felix-schwarz
Copy link
Contributor

@jesmrec @hosy (3) is a known issue also affecting the Desktop client: owncloud/ocis#3788 @micbar told me it's about to be addressed with top priority by the ocis team for the 2nd public beta.

The public alpha 1 of the iOS client 12.0 with spaces support contains a temporary workaround, so interested users could also use that if needed.

@jesmrec
Copy link
Contributor

jesmrec commented May 16, 2022

(1) -> fixed
(2) -> behaviour improved. No blinking when browsing. Sometimes it happens after some seconds but it's really mitigated
(3) -> wont fix here

@jesmrec
Copy link
Contributor

jesmrec commented May 16, 2022

11.10 only contains some fixes and improvements that (should) not affect the main features. So, final testing was reduced to automatic tests, basic manual checks and upgrade testing:

Xcode version: 13.3.1 (13E500a)

Automatic test report: https://reports.cucumber.io/reports/7fd7a553-61aa-4570-9d50-8227ce4479ac

Devices:

iPhoneXR, iOS v15.4.1
iPadAir2, iPadOS v14.8

Basic checks:

  • Basic auth
  • OAuth2: create/revoke session
  • OIDC: create session -> known issue (status.php version not useful. ocis#3788)
  • Av. offline files/folders
  • Transfers (uploads/downloads)
  • Files App basics
  • Upgrade from 10.9.1

Approved commits:

app: 6b238b5
sdk: b1bda6a7

Ready to go!

@jesmrec jesmrec added the Approved by QA Approved by QA label May 16, 2022
@hosy hosy requested a review from felix-schwarz May 16, 2022 13:10
<key>Title</key>
<string>Shortcuts Action</string>
<key>Subtitle</key>
<string>The shortcuts action Delete Path Item did not provided configured accounts.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo: provided should be provide.

@felix-schwarz felix-schwarz self-requested a review May 16, 2022 14:52
@hosy hosy merged commit e68ae02 into master May 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the milestone/11.10.0 branch May 17, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RELEASE] 11.10.0
4 participants