Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/shortcuts-delete-path-item-accounts] Shortcuts: Delete Path Item - No Accounts provided #1125

Merged
merged 1 commit into from May 9, 2022

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented May 4, 2022

Description

Account options were not dynamically provided for action "Delete Account Item", because of wrong intent configuration

Related Issue

#1123

Motivation and Context

How Has This Been Tested?

  • In Shortcuts:
  • Add action Delete Path Item
  • Try to select an configured account

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

…e Account Item", because of wrong intent configuration
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Matthias Hühne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hosy hosy self-assigned this May 4, 2022
@hosy hosy added this to the 11.10.0-Current milestone May 4, 2022
@hosy hosy added the bug Something isn't working label May 4, 2022
@hosy hosy requested review from felix-schwarz and jesmrec May 4, 2022 09:41
@jesmrec
Copy link
Contributor

jesmrec commented May 4, 2022

Fixed!

@jesmrec jesmrec added the Approved by QA Approved by QA label May 4, 2022
@hosy hosy merged commit 95dde3a into milestone/11.10.0 May 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/shortcuts-delete-path-item-accounts branch May 9, 2022 07:29
hosy added a commit that referenced this pull request May 17, 2022
* set up a new version 11.10.0

* [feature/openssl-1.1.1] Migration to OpenSSL 1.1.0 (#1116)

* - migrated code to new OpenSSL 1.1.1 API
- using OpenSSL Package

* - update SDK

* - update ios-sdk

Co-authored-by: Matthias Hühne <>
Co-authored-by: Felix Schwarz <fs-git@iospirit.com>

* #1114 If app is build as EMM version, the app shows an licensing error, when running shortcut intents (could not read app bundle identifier in extension) (#1122)

Co-authored-by: Matthias Hühne <>

* [feature/iOS-15-SDK] Build with iOS 15 SDK (#1121)

* #1066 support for iOS 15 SDK: Solving UI issues, removing unneeded code

* - updated Xcode version for fastlane
- fastlane readme update

Co-authored-by: Matthias Hühne <>

* #1123 Account options were not dynamically provided for action "Delete Account Item", because of wrong intent configuration (#1125)

Co-authored-by: Matthias Hühne <>

* [fix/copy-timeout] Fix copy timeout (#1119)

* - update SDK for improved error handling
- add environment variable switch to enable/disable action-timeout-simulator host simulator

* - update SDK with changes addressing code review findings by @hosy in #1119

* - added release notes changelog files
- added in-app release notes
- changed app version number
- removed beta build warning

* added OpenSSL changelog entry

* updated Xcode version

* only perform table updates, when query is final to prevent flickering and showing empty folder message (QA finding 1, 2)

* moved changelog folder to new release folder

* updated fastlane release notes for App Store

* - change SDK reference from develop to release commit

* fixed typo

Co-authored-by: Matthias Hühne <>
Co-authored-by: Felix Schwarz <fs-git@iospirit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants