Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/tus-support] Add Tus upload support (WIP) #66

Closed
wants to merge 3 commits into from

Conversation

felix-schwarz
Copy link
Collaborator

Description

Adds what's needed to support Tus for uploads

Related Issue

#65

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

	- NSString+TUSMetadata: conversion from dictionary to Upload-Metadata - and back
	- OCTUSHeader: new class to simplify parsing, building and conversion of TUS-related headers
	- OCTUSJob: new class to manage the current status of a TUS upload
	- OCTUSJobSegment: new class to abstract away file segmentation details for TUS uploads
- OCConnection:
	- add new OCConnectionDelegate method to inject/modify TUS capabilities / settings
	- add new OCConnectionOptionTemporarySegmentFolderURLKey option key to provide a temporary folder to store file segments in when performing uploads via TUS
	- add code to upload files via TUS where available
- OCSyncActionUpload: add OCConnectionOptionTemporarySegmentFolderURLKey option to ensure persistence of temporary segment files
- OCEvent:
	- add OCTUSHeader, OCTUSJob and OCTUSJobSegment to .safeClasses
	- modernize initWithCoder
- OCHTTP:
	- add OCHTTPStaticHeaderFields type and switch OCHTTPResponse over
	- add OCHTTPMethodPATCH method
	- add support for TUS capabilities information provided via the capabilities endpoint
- OCConnection
	- apply OCCapabilities.tusMaxChunkSize to TUS uploads if available
- OCTUSHeader
	- clarify .maximumSize is the maximum file size and add new .maximumChunkSize to supply a maximum chunk size
	- add new OCTUSCapabilityKey and OCTUSCapability types as needed by OCCapabilities
@felix-schwarz felix-schwarz changed the base branch from feature/message-queue to develop May 27, 2020 16:34
@felix-schwarz felix-schwarz changed the base branch from develop to feature/message-queue May 27, 2020 16:34
@felix-schwarz
Copy link
Collaborator Author

felix-schwarz commented May 27, 2020

This branch has been backported to develop via develop-tus, which has then been merged to develop. Further TUS development will now take place in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants