Don't enable market app when trying an offline upgrade (9.1.4 -> 10.0.2)

[patrickjahns]

Steps to reproduce

1. Install owncloud 9.1.4
2. Download and prepare 10.0.2
3. Disable marketplace
4. Attempt to upgrade owncloud from 10.0.2

Expected behaviour

The marketplace app should stay disable during attempted offline upgrade (and show an error when upgrade is not possible to incompatible apps)

Actual behaviour

During occ:upgrade marketplace will be enabled and will attempt to conncect to the marketplace

root@dima:/var/www/owncloud# sudo -u www-data php occ app:disable market
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
market disabled

root@dima:/var/www/owncloud# sudo -u www-data php occ app:list
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Disabled:
...
  - market
...

root@dima:/var/www/owncloud# sudo -u www-data php occ upgrade -vvv
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
2017-07-17T12:39:55+00:00 Set log level to debug
2017-07-17T12:39:55+00:00 Repair step: Repair MySQL database engine
2017-07-17T12:39:55+00:00 Repair step: Repair MySQL collation
2017-07-17T12:39:55+00:00 Repair info: All tables already have the correct collation -> nothing to do
2017-07-17T12:39:55+00:00 Repair step: Repair SQLite autoincrement
2017-07-17T12:39:55+00:00 Repair step: Repair duplicate entries in oc_lucene_status
2017-07-17T12:39:55+00:00 Repair info: lucene_status table does not exist -> nothing to do
2017-07-17T12:39:55+00:00 Repair step: Upgrade app code from the marketplace
2017-07-17T12:39:55+00:00 Repair info: Enabling market app to assist with update
2017-07-17T12:39:55+00:00 Repair info: Using market to update existing apps
2017-07-17T12:39:55+00:00 Repair info: Attempting to update the following existing but incompatible app from market: activity, files_pdfviewer, files_texteditor, gallery
2017-07-17T12:39:55+00:00 Repair info: Fetching app from market: activity
2017-07-17T12:39:58+00:00 Repair warning: GuzzleHttp\Exception\ConnectException
2017-07-17T12:39:58+00:00 Repair warning: cURL error 7: Failed to connect to marketplace.owncloud.com port 443: No route to host
...

root@dima:/var/www/owncloud# sudo -u www-data php occ app:list
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Enabled:
...
  - market: true
...

@cdamken

[patrickjahns]

Should we open an issue in core? Since it is related to:
https://github.com/owncloud/core/blob/master/lib/private/Repair/Apps.php#L112

[DeepDiver1975]

Should we open an issue in core? Since it is related to:
https://github.com/owncloud/core/blob/master/lib/private/Repair/Apps.php#L112

it's perfectly fine to open a PR in core and reference this issue in here

[VicDeo]

@patrickjahns @DeepDiver1975 i don't think it to be a bug.
As soon as 9.1 might have no market app it is good idea to enable it by default.
There is a brand new switch for offline instances #88
to prevent searching for updates in internet (not backported to stable10 yet)

[DeepDiver1975]

There is a brand new switch for offline instances #88
to prevent searching for updates in internet (not backported to stable10 yet)

can i ask you to double check if everything has been backported? THX

[VicDeo]

@DeepDiver1975 what do you mean by everything?
Direct backport is not possible because #91 is based on changes from another PR

[patrickjahns]

So the backport for an offline instances is not possible?

Any other idea how to solve this when someone with an offline instances wants to upgrade?

[PVince81]

quoting from chat:

PVince81: the reason for auto-enabling market app was for the seamless experience if you had "appstoreenabled"
PVince81: if "appstoreenabled" was false in OC 9.1 then updated should not enable market app, but I'm not sure whether we put in this logic. If not, then that's what we should do
DeepDiver1975: if the market is disabled - it will remain disabled and a warning is being output to the user
DeepDiver1975: but this applies only if the market as was explicitly disabled - on upgrade from 9.x to 10 market is installed and enabled by default
DeepDiver1975: so yes - evaluating appstoreenabled and has_internet_connection before enabling market app sounds reasonable