Compiling mirall from master currently fails

[Caffe1neAdd1ct]

Make error is as follows:

[ 7%] Building CXX object src/CMakeFiles/owncloudsync.dir/mirall/folderman.cpp.o
In file included from /home/kandrews/owncloud-build/mirall/src/mirall/folder.h:22:0,
from /home/kandrews/owncloud-build/mirall/src/mirall/folderman.h:23,
from /home/kandrews/owncloud-build/mirall/src/mirall/folderman.cpp:15:
/home/kandrews/owncloud-build/mirall/src/mirall/csyncthread.h:57:40: error: ‘CSYNC_STATUS’ has not been declared
static QString csyncErrorToString( CSYNC_STATUS);
^
make[2]: *** [src/CMakeFiles/owncloudsync.dir/mirall/folderman.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/owncloudsync.dir/all] Error 2
make: *** [all] Error 2

I think it has something to do with the following commit:

84a40dc#diff-1ec11ed609725d1ba54113a43d2d6cf0

Removal:
-Q_DECLARE_METATYPE(CSYNC_STATUS)

Usage:
static QString csyncErrorToString( CSYNC_STATUS);

[danimo]

You are using the wrong csync version. Either use mirall master with the ocsync from http://git.csync.org/users/owncloud/csync.git/log/?h=ocsync

or use mirall 1.4 branch with http://git.csync.org/users/freitag/csync.git/log/?h=dav.

[Caffe1neAdd1ct]

This page needs updating then:

http://doc.owncloud.org/desktop/1.2/building.html#generic-build-instructions

As it references:
git clone git://git.csync.org/users/freitag/csync.git ocsync

Then
git checkout dav

So it should be
git clone git://git.csync.org/users/owncloud/csync.git ocsync
git checkout ocsync

?

[beedaddy]

I think that's correct, now it builds successfully.

[danimo]

No, it doesn't. http://doc.owncloud.org/desktop/1.2/building.html#generic-build-instructions, as the name indicates, is for building 1.2. http://doc.owncloud.org/desktop/1.4/building.html#generic-build-instructions is for 1.4. and what's in master is in git.

[Caffe1neAdd1ct]

The 1.4 guide also references
git clone git://git.csync.org/users/freitag/csync.git ocsync
git checkout dav

instead of
git clone git://git.csync.org/users/owncloud/csync.git ocsync
git checkout ocsync

and @beedaddy has confirmed he can build mirall master with git://git.csync.org/users/owncloud/csync.git repo without the CSYNC_STATUS error.

Which repo and which branch are we to use:

git clone git://git.csync.org/users/freitag/csync.git ocsync
git checkout dav

Or

git clone git://git.csync.org/users/owncloud/csync.git ocsync
git checkout ocsync

?

The 1.2 and 1.4 build guides are basically exactly the same, both say to use master mirall and dav of csync (users/freitag) which after your tip to use csync (users/owncloud) which successfully builds seems to suggest the build guides are a little misleading.

[beedaddy]

I also got the hint using the other repo from here: http://www.mail-archive.com/owncloud@kde.org/msg10655.html

[danimo]

@beedaddy Well, if you want to develop master then that's the way to go. If you want to modify the latest stable version, follow the 1.4 documentation.

@Caffe1neAdd1ct: The 1.4 guide is completely right about this, because you need the dav branch for 1.4. It depends if you want to build a 1.4 version of latest master (which will be 1.5). If you want 1.4, just use the source tar balls from the client download page and don't bother with git if you find it too complicated.

[beedaddy]

@danimo Well, yes, using master might not be a good idea. The reason for this was that a recent patch solved the crash bug. But I now used the stable source packages, applied the mentioned patch, adjusted some CMake files in order to build with libneon, and ... voila. It builds and seems to run without the annoying crash.