Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Folders not shown #955

Closed
borekon opened this issue Mar 16, 2022 · 8 comments
Closed

[BUG] Folders not shown #955

borekon opened this issue Mar 16, 2022 · 8 comments
Labels

Comments

@borekon
Copy link

borekon commented Mar 16, 2022

When clicking Folders on the left pane the page keeps loading (the spin thing in the middle keeps rotating) and nothing happens.
In console mode there's an error:
image

Working like a charm from android's app DSUB

@paulijar paulijar added the Bug label Mar 16, 2022
@paulijar
Copy link
Collaborator

Thanks for the report. If you fetch the URL <path_to_your_cloud>/index.php/apps/music/api/folders, then what does the result look like?

@borekon
Copy link
Author

borekon commented Mar 17, 2022

This is what it shows:
[{"name":"","parent":null,"trackIds":[],"id":1219540},{"name":"VA-Mayday_25_Years_The_History_Of_Rave","parent":1219540,"trackIds":[],"id":1493935},{"name":"Los 500 mejores chistes","parent":2392032,"trackIds":[],"id":2392033},{"name":"Navidad","parent":1219540,"trackIds":[],"id":1267519},{"name":"Thunderdome","parent":1219540,"trackIds":[],"id":1249263},{"name":"Chistes","parent":1219540,"trackIds":[],"id":2392032},{"name":"ByN","parent":1219540,"trackIds":[],"id":1249330},{"name":"BandasSonoras","parent":1219540,"trackIds":[],"id":1267521},{"name":"Ahora 2009","parent":1219540,"trackIds":[],"id":2585397},{"name":"files_trashbin","parent":6,"trackIds":[],"id":3176495},{"name":"","parent":-1,"trackIds":[],"id":6},null]

Only posted the albums with empty trakcids ( i think thats the problem...)

@borekon borekon closed this as completed Mar 17, 2022
@borekon borekon reopened this Mar 17, 2022
@paulijar
Copy link
Collaborator

The problem is probably now the very last array entry null. I don't know, what could cause such entry to appear, but I need to take a look at the code once I have time.

@borekon
Copy link
Author

borekon commented Mar 18, 2022

I did a database reset from GUI and the problem was gone... but i had to import again playlists
Added a couple of MP3 and happened again...

paulijar added a commit that referenced this issue Apr 17, 2022
In case the oc_filecache table would contain some invalid parent references
(i.e. the file index is somehow corrupted), ignore those when building the
folder tree. Previously, such references caused null values to be included in
the result of the REST API method `api/folders`, which prevented the web UI
from showing any folders.

refs #955
@paulijar
Copy link
Collaborator

It took some time as I was busy with other things, but now I have made one fix which might help on this issue. If you want to test if it fixes the issue for you, you may download the file https://raw.githubusercontent.com/owncloud/music/master/lib/BusinessLayer/TrackBusinessLayer.php and replace the corresponding file on your v1.5.1 installation.

@borekon
Copy link
Author

borekon commented Apr 18, 2022

Replaced file and now folders are shown again!!
Thanks!!

@paulijar
Copy link
Collaborator

Great, thanks for the confirmation!

@paulijar
Copy link
Collaborator

paulijar commented May 8, 2022

The fix for this is now released in Music v1.5.2.

@paulijar paulijar closed this as completed May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants