Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Fix external app urls #83

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Fix external app urls #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2805429
Fix the default external app urls
kulmann Sep 10, 2020
1c8dc07
Add changelog
kulmann Sep 10, 2020
c4771b0
Change external app config to just use the paths of the js bundles
kulmann Sep 10, 2020
97d701a
Fix changelog
kulmann Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/fix-external-app-urls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Fix external app URLs

The URLs for the default set of external apps was hardcoded to localhost:9200. We fixed that by using relative paths instead.

https://github.com/owncloud/product/issues/218
https://github.com/owncloud/ocis-phoenix/pull/83
4 changes: 2 additions & 2 deletions pkg/service/v0/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ func (p Phoenix) getPayload() (payload []byte, err error) {
p.config.Phoenix.Config.ExternalApps = []config.ExternalApp{
{
ID: "accounts",
Path: "https://localhost:9200/accounts.js",
Path: "/accounts.js",
},
{
ID: "settings",
Path: "https://localhost:9200/settings.js",
Path: "/settings.js",
},
}
}
Expand Down