server returns 500 when trying to access a not existing file

[individual-it]

trying to get a file that does not exist e.g. curl http://localhost:9140/remote.php/webdav/home/does-not-exist.txt -u einstein:relativity -v

the result code should be 404, but is 500

[PVince81]

seems some tests have been tagged with this issue but seem unrelated:

tests/acceptance/features/apiComments/createComments.feature|1| @api @TestAlsoOnExternalUserBackend @comments-app-required @files_sharing-app-required @skipOnOcis @issue-ocis-reva-13
tests/acceptance/features/apiComments/deleteComments.feature|1| @api @TestAlsoOnExternalUserBackend @comments-app-required @skipOnOcis @issue-ocis-reva-13
tests/acceptance/features/apiComments/editComments.feature|1| @api @TestAlsoOnExternalUserBackend @comments-app-required @skipOnOcis @issue-ocis-reva-13
tests/acceptance/features/apiComments/comments.feature|1| @api @TestAlsoOnExternalUserBackend @comments-app-required @skipOnOcis @issue-ocis-reva-13
tests/acceptance/features/apiAuthWebDav/webDavDELETEAuth.feature|32| @skipOnOcis @issue-ocis-reva-13

the comments issue seems to be https://github.com/owncloud/ocis-reva/issues/38

@individual-it

[PVince81]

I did a manual test with the above command and the bug seems to be fixed already (likely through cs3org/reva#542)

so next up:

• fix up the ticket references issue mentioned above: Adjust test tag issue number for ocis reva comments core#37331
• find whether there is an actual test for this case and enable it (if not already)

[PVince81]

It seems now it returns 204 instead of 404:

  @skipOnOcis @issue-ocis-reva-13
  Scenario: send DELETE requests to another user's webDav endpoints as normal user                                    # /srv/www/htdocs/owncloud/tests/acceptance/features/apiAuthWebDav/webDavDELETEAuth.feature:34
    When user "user1" requests these endpoints with "DELETE" including body then the status codes should be as listed # OCSContext::userSendsRequestToTheseEndpointsWithBody()
      | endpoint                                      | http-code | body          |
      | /remote.php/dav/files/user0/textfile0.txt     | 404       | doesnotmatter |
      | /remote.php/dav/files/user0/PARENT            | 404       | doesnotmatter |
      | /remote.php/dav/files/user0/PARENT/parent.txt | 404       | doesnotmatter |
      Got unexpected HTTP code while sending request to endpoint /remote.php/dav/files/user0/textfile0.txt
      Failed asserting that 204 matches expected '404'.

--- Failed scenarios:

    /srv/www/htdocs/owncloud/tests/acceptance/features/apiAuthWebDav/webDavDELETEAuth.feature:34

[PVince81]

@individual-it I've adjusted the comments related tests here: owncloud/core#37331

[PVince81]

seems we can close this: it now returns 204 instead of 500, this problem is tracked in https://github.com/owncloud/ocis-reva/issues/163

I added a note there to also unskip the issue 13 when solved