Implement expiration date for shares

[PVince81]

Expiration date of share is not yet supported in OCIS for any of the share types:

• user
• group
• public link

The API test scenarios for these are currently running in CI and are in the expected-failures file.

ToDo:

• find all the share expiration scenarios and put them together in the expected-failures file, linked to this issue, and in sections for user, group, and public link shares [full-ci] [tests-only] Sort out expected-failures for share expiration date #2412
• implement in oCIS
• make it configurable in oCIS with similar options to oC10

This was the original post, preserved for posterity:

As I can see in the code this is not implemented yet.

As for tests, it seems most will stay disabled because we need to set some settings with occ...

• tag the matching tests with this ticket
• implement expiration date for user shares
• somehow make it configurable as we have no occ in ocis yet
• enable tests

@pmaier1 FYI for adding to the roadmap somewhere. feel free to move to another project than MVP as this is blocked by the config stuff
@individual-it FYI

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[phil-davis]

This issue specifically mentions expiration date for user shares. I think that we also want expiration dates for group shares and public link shares. I suspect that implementation for all of these will be done together.

@pmaier1 is this issue still current (or is there another issue somewhere about this)?

Do we expand this issue to also cover group shares an public link shares? Or create separate issues?

[phil-davis]

Assigned myslef so that I see this next week. This is a good example of a feature that is not implemented yet. Currently some of the related test scenarios are tagged in a way that they do not run in oCIS CI, and some are running in oCIS CI and listed in expected-failures. We need a consistent process for tagging tests.

[pmaier1]

@pmaier1 is this issue still current (or is there another issue somewhere about this)?

This is still current but it is clearly a feature on the roadmap, not a bug. I'd be happy to exclude this feature from our hardening efforts and start working on it when the time has come.

[phil-davis]

@pmaier1 should I edit the title to be "Implement expiration date for all shares" and mention the various share types in the top ost?
(i.e. make this an issue about all expiration dates)

[pmaier1]

@pmaier1 should I edit the title to be "Implement expiration date for all shares" and mention the various share types in the top ost?

If I'm not mistaken, the expiration date for links feature is already implemented. If that's not the case, I agree with your proposal.

[phil-davis]

Note:
Scenario Outline: sharing with default expiration date enabled but not enforced for groups, user shares with expiration date

That fails (and other group expiration date test scenarios)

Scenario Outline: Create a public link with default expiration date set and max expiration date enforced and access using the public WebDAV API

That also fails: apiSharePublicLink1/createPublicLinkShare.feature:652 is in the expected failures file and I can see it failing in a recent drone build.

So share expiration is not yet working for any of the share type. I will adjust the top post.

[pmaier1]

These policies (enforce expiration date for user shares / public links) are also new features for oCIS - to be handled via the roadmap.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[phil-davis]

This issue is referenced in expected-failures. Reopening.

[ScharfViktor]

expiration date for shares works correct. I close issue
The tests were removed from the expected failure file and rewritten using e2e owncloud/web#10292