Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing non-existing public link should return 404, not 500 #1268

Closed
PVince81 opened this issue Jun 18, 2020 · 3 comments
Closed

Accessing non-existing public link should return 404, not 500 #1268

PVince81 opened this issue Jun 18, 2020 · 3 comments
Projects

Comments

@PVince81
Copy link
Contributor

Steps

Run test "Uploading file to a public upload-only share using new public API that was deleted does not work" from "tests/acceptance/features/apiSharePublicLink2/uploadToPublicLinkShare.feature:61"

Expected

404 error

Actual

500 error

Logs

==> reva-frontend.log <==
2020-06-18T14:31:21+02:00 ERR error sending grpc stat request error="rpc error: code = Unknown desc = gateway: grpc failed with code CODE_NOT_FOUND" pkg=rhttp service=reva traceid=d1f9cc025d3d809d27f39a68b6286c6a
2020-06-18T14:31:21+02:00 ERR http end="18/Jun/2020:14:31:21 +0200" host=127.0.0.1 method=PUT pkg=rhttp proto=HTTP/1.1 service=reva size=0 start="18/Jun/2020:14:31:21 +0200" status=500 time_ns=160803601 traceid=d1f9cc025d3d809d27f39a68b6286c6a uri=/remote.php/dav/public-files/SOqHuPhZGPei/whateverfilefortesting.txt url=/remote.php/dav/public-files/SOqHuPhZGPei/whateverfilefortesting.txt

Seems it's simply some missing error handling where the GRPC code must be translated to an HTTP response.

@PVince81
Copy link
Contributor Author

Could be similar to https://github.com/owncloud/ocis-reva/issues/280

@PVince81
Copy link
Contributor Author

similar issue in OC 10: owncloud/core#36055

@butonic butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021
@refs
Copy link
Member

refs commented Jan 18, 2021

This is not on any expected failures. Is it still the case that it fails?

@refs refs closed this as completed Jan 18, 2021
oCIS MVP automation moved this from To do to Done Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
oCIS MVP
  
Done
Development

No branches or pull requests

2 participants